Skip to content

Add thumbcache parser #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Nov 3, 2022
Merged

Add thumbcache parser #1

merged 25 commits into from
Nov 3, 2022

Conversation

@Miauwkeru
Copy link
Contributor

@Miauwkeru Miauwkeru commented Oct 27, 2022 •
edited
Loading

(DIS-1352)

Poeloe
Poeloe reviewed Oct 27, 2022
View reviewed changes
Copy link

@Poeloe Poeloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review comments

README.md
@@ -1,3 +1,7 @@
# dissect.thumbcache
Copy link

@Poeloe Poeloe Oct 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the default template for the readme. See dissect.target for example (but you know ;))

cecinestpasunepipe
cecinestpasunepipe suggested changes Oct 27, 2022
View reviewed changes
cecinestpasunepipe
cecinestpasunepipe suggested changes Oct 28, 2022
View reviewed changes
Schamper
Schamper requested changes Oct 28, 2022
View reviewed changes
Poeloe
Poeloe reviewed Oct 28, 2022
View reviewed changes
Poeloe
Poeloe reviewed Oct 28, 2022
View reviewed changes
@Miauwkeru Miauwkeru requested a review from Schamper October 28, 2022 14:21
Schamper
Schamper requested changes Oct 31, 2022
View reviewed changes
Schamper
Schamper reviewed Oct 31, 2022
View reviewed changes
@Schamper
Copy link
Member

Schamper commented Nov 2, 2022 •
edited
Loading

Can you add all the useful classes to __init__.py in __all__? And the minimal Python version that's doing the rounds in the other repos?

@Miauwkeru
Copy link
Contributor Author

Miauwkeru commented Nov 2, 2022

Can you add all the useful classes to __init__.py in __all__? And the minimal Python version that's doing the rounds in the other repos?

Sure! I had a feeling I was forgetting something

@Miauwkeru Miauwkeru requested a review from Schamper November 2, 2022 14:13
@Miauwkeru Miauwkeru merged commit 1753909 into main Nov 3, 2022
@Miauwkeru Miauwkeru deleted the DIS-1352_add-thumbcache-plugin branch November 7, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Poeloe Poeloe Poeloe left review comments

@Schamper Schamper Schamper approved these changes

+1 more reviewer

@cecinestpasunepipe cecinestpasunepipe cecinestpasunepipe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Miauwkeru @Schamper @Poeloe @cecinestpasunepipe