Fix EOF read error for char arrays in a BEEF0004 shellbag #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #730 +/- ##
==========================================
+ Coverage 74.92% 74.97% +0.04%
==========================================
Files 295 295
Lines 25070 25070
==========================================
+ Hits 18784 18796 +12
+ Misses 6286 6274 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Poeloe
requested changes
Jun 25, 2024
Contributor
Poeloe
left a comment
Poeloe
left a comment
There was a problem hiding this comment.
Could you add a test case?
Poeloe
requested changes
Jun 27, 2024
| self.localized_name = c_bag.char[None](fh) | ||
|
|
||
| if version >= 7 and localized_name_offset > 0: | ||
| self.localized_name = c_bag.wchar[None](fh) |
Contributor
There was a problem hiding this comment.
Could you add another test case that also evaluates this line? 😄
Poeloe
requested changes
Jun 27, 2024
| from dissect.target.plugins.os.windows.regf.shellbags import parse_shell_item_list | ||
|
|
||
|
|
||
| def test_parse_shell_item_list_chars() -> None: |
Contributor
There was a problem hiding this comment.
Suggested change
| def test_parse_shell_item_list_chars() -> None: | |
| def test_parse_shell_item_list_char() -> None: |
| assert extension.localized_name == b"@shell32.dll,-21786" | ||
|
|
||
|
|
||
| def test_parse_shell_item_list_wchar() -> None: |
Contributor
There was a problem hiding this comment.
Suggestion: Maybe use pytest.parameterize and use shellbag, modification_time, long_name and localized_name as parameters? Then use id to distinguish the test cases char and wchar
Poeloe
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.