Skip to content

Conversation

@narimantos
Copy link
Contributor

indicate when cache is used
(DIS-2985)

@narimantos narimantos marked this pull request as ready for review May 21, 2024 14:44
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 75.17%. Comparing base (94cd431) to head (6ff933f).

Files Patch % Lines
dissect/target/helpers/cache.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #710      +/-   ##
==========================================
- Coverage   75.18%   75.17%   -0.01%     
==========================================
  Files         292      292              
  Lines       24855    24857       +2     
==========================================
  Hits        18686    18686              
- Misses       6169     6171       +2     
Flag Coverage Δ
unittests 75.17% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@narimantos narimantos changed the title Indicate when cache is used via info logger Indicate when cache is used May 22, 2024
@narimantos narimantos force-pushed the indactor_cache_used branch 2 times, most recently from 2177273 to 9efca94 Compare May 22, 2024 09:20
@narimantos narimantos force-pushed the indactor_cache_used branch from 9efca94 to 6ff933f Compare May 22, 2024 13:46
@narimantos narimantos requested a review from Schamper May 22, 2024 13:47
@narimantos narimantos force-pushed the indactor_cache_used branch from 6ff933f to 6f449d4 Compare May 22, 2024 15:01
@narimantos narimantos requested a review from Schamper May 22, 2024 15:02
@narimantos narimantos merged commit b514c07 into main May 23, 2024
@narimantos narimantos deleted the indactor_cache_used branch May 23, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants