Skip to content

Conversation

@JSCU-CNI
Copy link
Contributor

This PR improves the support and robustness for static and dynamic netplan configuration parsing on linux targets.

  1. added tests for static netplan configurations
  2. the messages plugin now parses /var/lib/installer/syslog* and /var/lib/cloud-init.log as well.
  3. parse_unix_dhcp_log_messages now searches output from the messages and journal plugins
  4. ips no longer breaks when encountering malformed or empty yaml files

@Horofic Horofic self-requested a review February 20, 2024 17:37
@codecov
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 90.54054% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 73.99%. Comparing base (a0c6c9f) to head (3793004).

❗ Current head 3793004 differs from pull request most recent head ee7b0e1. Consider uploading reports for the commit ee7b0e1 to get more accurate results

Files Patch % Lines
dissect/target/helpers/network_managers.py 90.47% 4 Missing ⚠️
dissect/target/plugins/os/unix/log/messages.py 90.62% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
- Coverage   74.02%   73.99%   -0.03%     
==========================================
  Files         285      284       -1     
  Lines       23578    23534      -44     
==========================================
- Hits        17454    17415      -39     
+ Misses       6124     6119       -5     
Flag Coverage Δ
unittests 73.99% <90.54%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Stefan de Reuver <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 90.76923% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 74.97%. Comparing base (f433711) to head (e3d5ce1).

Files Patch % Lines
dissect/target/helpers/network_managers.py 89.74% 4 Missing ⚠️
dissect/target/plugins/os/unix/log/messages.py 92.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
+ Coverage   74.93%   74.97%   +0.04%     
==========================================
  Files         288      288              
  Lines       24145    24172      +27     
==========================================
+ Hits        18093    18124      +31     
+ Misses       6052     6048       -4     
Flag Coverage Δ
unittests 74.97% <90.76%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JSCU-CNI JSCU-CNI requested a review from Horofic April 8, 2024 10:40
Copy link
Member

@Horofic Horofic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, miss clicked on "Approve"

Co-authored-by: Stefan de Reuver <[email protected]>
@Horofic Horofic merged commit bdd4426 into fox-it:main Apr 15, 2024
@JSCU-CNI JSCU-CNI deleted the improvement/unix-ips-netplan-journal branch April 15, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants