Skip to content

Conversation

@JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Feb 16, 2024

This PR adds support for extracting saved passwords and decrypting cookie values from Chromium-based browsers and Firefox on both Windows and Linux targets.

This PR also adds support for decrypting DPAPI user secrets as the current DPAPI implementation only accounts for system secrets.

@Schamper Schamper self-requested a review February 16, 2024 13:54
@JSCU-CNI
Copy link
Contributor Author

Implemented your feedback in d694c9b.

@JSCU-CNI JSCU-CNI requested a review from Schamper April 8, 2024 10:40
@Schamper
Copy link
Member

Schamper commented Apr 9, 2024

I've committed some small changes with 4834771. Mostly type hint, but also the option to decrypt an DPAPI secret of a specific user. Lmk if this still works as expected.

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 71.59091% with 125 lines in your changes are missing coverage. Please review.

Project coverage is 75.02%. Comparing base (fe66118) to head (b88a6e3).

Files Patch % Lines
dissect/target/plugins/apps/browser/firefox.py 69.89% 59 Missing ⚠️
dissect/target/plugins/apps/browser/chromium.py 73.91% 30 Missing ⚠️
dissect/target/plugins/os/windows/dpapi/dpapi.py 75.00% 11 Missing ⚠️
dissect/target/plugins/os/windows/dpapi/crypto.py 44.44% 5 Missing ⚠️
dissect/target/plugins/apps/ssh/putty.py 50.00% 4 Missing ⚠️
...issect/target/plugins/os/unix/linux/fortios/_os.py 33.33% 4 Missing ⚠️
...sect/target/plugins/os/windows/dpapi/master_key.py 73.33% 4 Missing ⚠️
dissect/target/plugins/os/windows/catroot.py 62.50% 3 Missing ⚠️
dissect/target/plugins/os/windows/sam.py 57.14% 3 Missing ⚠️
dissect/target/loaders/itunes.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
+ Coverage   74.99%   75.02%   +0.02%     
==========================================
  Files         288      288              
  Lines       24192    24588     +396     
==========================================
+ Hits        18143    18447     +304     
- Misses       6049     6141      +92     
Flag Coverage Δ
unittests 75.02% <71.59%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper
Copy link
Member

Can you rebase on main? Unfortunately due to a bug in GitHub I can't fix LFS issues on PR branches. Protip, man git-lfs-migrate.

@JSCU-CNI
Copy link
Contributor Author

Could you open a PR on our fork to fix this perhaps @Schamper?

@Schamper Schamper force-pushed the feature/add-browser-password-funcs branch from 6443a11 to 42fe5b5 Compare April 10, 2024 20:12
@Schamper
Copy link
Member

Could you open a PR on our fork to fix this perhaps @Schamper?

Fixed it I think.

@JSCU-CNI
Copy link
Contributor Author

Fixed it I think.

Thanks!

@JSCU-CNI JSCU-CNI requested a review from Schamper April 15, 2024 09:15
@Schamper Schamper merged commit bf82f59 into fox-it:main Apr 17, 2024
@JSCU-CNI JSCU-CNI deleted the feature/add-browser-password-funcs branch April 18, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants