-
Notifications
You must be signed in to change notification settings - Fork 71
Add some benchmarks #1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some benchmarks #1129
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1129 +/- ##
==========================================
+ Coverage 77.86% 77.90% +0.03%
==========================================
Files 358 358
Lines 32622 32622
==========================================
+ Hits 25401 25413 +12
+ Misses 7221 7209 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can we make the journal (and maybe the walkfs) benchmark more targeted? For example, only parse a single entry. |
What do you propose? Call |
It's tricky for sure, since just benchmarking It's a bit annoying that CodSpeed does not yet support the Perhaps for the time being initializing the plugin and calling a single next is just the best we can do until CodSpeed supports that. So basically a |
CodSpeed Performance ReportCongrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
Fixes #1126. Inspired (read: copy/paste'd) setup from fox-it/dissect.util#64.