Skip to content

Conversation

@JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Apr 24, 2025

This PR adds support for Google Chrome and Microsoft Edge v20 encrypted values.

We moved some stuff around in chromium.py, please let us know if this structure using DECRYPTION_MAP is preferred or not. Will add tests at a later time.

cookies = list(target_win_11_users_dpapi.chrome.cookies())
assert len(cookies) == 2

assert cookies[0].host == "werkenvoornederland.nl"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇳🇱

@codecov
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

Attention: Patch coverage is 70.58824% with 45 lines in your changes missing coverage. Please review.

Project coverage is 77.86%. Comparing base (81ff5f4) to head (04b6b45).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/plugins/apps/browser/chromium.py 70.39% 45 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1121   +/-   ##
=======================================
  Coverage   77.86%   77.86%           
=======================================
  Files         357      357           
  Lines       32439    32521   +82     
=======================================
+ Hits        25259    25323   +64     
- Misses       7180     7198   +18     
Flag Coverage Δ
unittests 77.86% <70.58%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JSCU-CNI JSCU-CNI requested a review from Schamper April 29, 2025 11:40
@JSCU-CNI
Copy link
Contributor Author

Thanks for the quick review @Schamper. Implemented your suggestions in 0b56eea and 2482261.

@JSCU-CNI JSCU-CNI requested a review from Schamper April 30, 2025 11:01
@JSCU-CNI JSCU-CNI requested a review from Schamper April 30, 2025 14:13
@JSCU-CNI JSCU-CNI requested a review from Schamper May 1, 2025 08:13
@Schamper Schamper merged commit bc77a4f into fox-it:main May 1, 2025
20 of 24 checks passed
@JSCU-CNI JSCU-CNI deleted the feature/browser-chromium-windows-decrypt-v20 branch May 1, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants