-
Notifications
You must be signed in to change notification settings - Fork 71
Add workaround for ANSI codes target-shell tests #1117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1117 +/- ##
==========================================
+ Coverage 77.82% 77.85% +0.03%
==========================================
Files 357 357
Lines 32363 32363
==========================================
+ Hits 25185 25195 +10
+ Misses 7178 7168 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
|
Seems like this is still broken on PyPy, regardless of the pexpect sanitation: @Schamper I think we should disable these tests for PyPy again, or perhaps contact the PyPy maintainers ;) |
|
I can't reproduce either, let me at least fix the pypy3.9 tests because of the faulty version check, and then we can disable this test for PyPy3.10. |
a5cdece to
817a470
Compare
2625fd1 to
c212510
Compare
c212510 to
424f708
Compare
Should fix #1111. Only tested locally on uv cpython 3.12 and 3.13 so far, curious to see if the regular CI test environments still pass.