Skip to content

Conversation

@JSCU-CNI
Copy link
Contributor

Should fix #1111. Only tested locally on uv cpython 3.12 and 3.13 so far, curious to see if the regular CI test environments still pass.

@codecov
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.85%. Comparing base (3c041e5) to head (424f708).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1117      +/-   ##
==========================================
+ Coverage   77.82%   77.85%   +0.03%     
==========================================
  Files         357      357              
  Lines       32363    32363              
==========================================
+ Hits        25185    25195      +10     
+ Misses       7178     7168      -10     
Flag Coverage Δ
unittests 77.85% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JSCU-CNI JSCU-CNI requested a review from Schamper April 24, 2025 13:13
@JSCU-CNI JSCU-CNI requested a review from Schamper April 24, 2025 13:35
Schamper
Schamper previously approved these changes Apr 24, 2025
@JSCU-CNI
Copy link
Contributor Author

JSCU-CNI commented Apr 24, 2025

Seems like we need to escape some additional characters and perhaps up the initial timeout for pypy.

@JSCU-CNI
Copy link
Contributor Author

JSCU-CNI commented Apr 28, 2025

Seems like this is still broken on PyPy, regardless of the pexpect sanitation:

buffer (last 100 chars): b'ls /home/u\t\n/home/u: No such directory\nubuntu:/$ '

@Schamper I think we should disable these tests for PyPy again, or perhaps contact the PyPy maintainers ;)

@Schamper
Copy link
Member

I can't reproduce either, let me at least fix the pypy3.9 tests because of the faulty version check, and then we can disable this test for PyPy3.10.

@Schamper Schamper force-pushed the fix/uv-cpython-pexpect branch 2 times, most recently from a5cdece to 817a470 Compare April 28, 2025 14:39
@Schamper Schamper force-pushed the fix/uv-cpython-pexpect branch 2 times, most recently from 2625fd1 to c212510 Compare April 28, 2025 15:17
@Schamper Schamper force-pushed the fix/uv-cpython-pexpect branch from c212510 to 424f708 Compare April 28, 2025 17:19
@Schamper Schamper merged commit d2d2668 into fox-it:main Apr 29, 2025
21 of 24 checks passed
@JSCU-CNI JSCU-CNI deleted the fix/uv-cpython-pexpect branch April 29, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shell prompt tab autocomplete test does not work in uv environments

2 participants