Skip to content

Conversation

@Schamper
Copy link
Member

@Schamper Schamper commented Apr 17, 2025

After we enabled test randomization, sometimes we get a test failure ontests/tools/test_query.py::test_invalid_functions and tests/tools/test_query.py::test_invalid_excluded_functions (https://github.com/fox-it/dissect.target/actions/runs/14494203513/job/40657657729?pr=1108)

However, I can't reproduce even with the same seed. I have a suspicion that a cached _generate_long_paths is the issue, so I moved the clearing of that cache from just the test_plugin.py file to every test in the suite.

@codecov
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.01%. Comparing base (8fb5b03) to head (8f8ea10).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1110   +/-   ##
=======================================
  Coverage   78.01%   78.01%           
=======================================
  Files         354      354           
  Lines       32049    32049           
=======================================
  Hits        25003    25003           
  Misses       7046     7046           
Flag Coverage Δ
unittests 78.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Schamper Schamper merged commit 35bcb0c into main Apr 17, 2025
20 of 23 checks passed
@Schamper Schamper deleted the clear-caches-pytest branch April 17, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants