Skip to content

Conversation

@JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Apr 2, 2025

This PR significantly improves the total time the tests take to complete on most systems. Limited to four threads to keep CI/CD workers happy.

Before on x86_64:

$ tox -e py313
...
2028 passed, 1 skipped in 120.77s (0:02:00)

After on x86_64:

$ tox -e py313
...
2028 passed, 1 skipped, 1 warning in 53.27s

@JSCU-CNI JSCU-CNI requested a review from Schamper April 3, 2025 13:18
@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.27%. Comparing base (8ba80d6) to head (89946d2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1089      +/-   ##
==========================================
+ Coverage   79.23%   79.27%   +0.03%     
==========================================
  Files         345      345              
  Lines       30656    30656              
==========================================
+ Hits        24290    24302      +12     
+ Misses       6366     6354      -12     
Flag Coverage Δ
unittests 79.27% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem all that much faster on GitHub but it's a nice local improvement 😂 I'd actually been running this locally for a bit already.

@Schamper Schamper merged commit f433f90 into fox-it:main Apr 3, 2025
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants