-
Notifications
You must be signed in to change notification settings - Fork 71
Add Windows MSN plugin #1084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows MSN plugin #1084
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:buzzer:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget the __init__.py.
Also, messaging vs chat? I assume we will want to use this namespace for applications such as WhatsApp, Signal, IRC, Slack, Teams, etc as well. I think chat is nice and short but I'm not sure what the most commonly used nomenclature would be for these apps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will leave the naming up to you. We currently use chat with other plugins, but I see no problem in refactoring that internally to what you pick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave it at chat until some zealot comes by and has a strong opinion on it.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1084 +/- ##
==========================================
+ Coverage 79.15% 79.17% +0.02%
==========================================
Files 342 344 +2
Lines 30281 30350 +69
==========================================
+ Hits 23968 24029 +61
- Misses 6313 6321 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR adds support to dissect for the Windows Live Messenger application. Currently works on
WLM 2009andMSN 7.5(on Windows 7 and XP), other versions might work too but have not been tested. Artifacts fromMessenger Plus! Liveare currently not supported.