Skip to content

Conversation

@JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Apr 1, 2025

This PR adds support to dissect for the Windows Live Messenger application. Currently works on WLM 2009 and MSN 7.5 (on Windows 7 and XP), other versions might work too but have not been tested. Artifacts from Messenger Plus! Live are currently not supported.

Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:buzzer:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the __init__.py.

Also, messaging vs chat? I assume we will want to use this namespace for applications such as WhatsApp, Signal, IRC, Slack, Teams, etc as well. I think chat is nice and short but I'm not sure what the most commonly used nomenclature would be for these apps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will leave the naming up to you. We currently use chat with other plugins, but I see no problem in refactoring that internally to what you pick.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave it at chat until some zealot comes by and has a strong opinion on it.

@JSCU-CNI JSCU-CNI requested a review from Schamper April 1, 2025 16:43
@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 88.40580% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.17%. Comparing base (e65a678) to head (6882374).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/plugins/apps/chat/msn.py 84.90% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1084      +/-   ##
==========================================
+ Coverage   79.15%   79.17%   +0.02%     
==========================================
  Files         342      344       +2     
  Lines       30281    30350      +69     
==========================================
+ Hits        23968    24029      +61     
- Misses       6313     6321       +8     
Flag Coverage Δ
unittests 79.17% <88.40%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Schamper Schamper merged commit bb9a488 into fox-it:main Apr 1, 2025
20 of 22 checks passed
@JSCU-CNI JSCU-CNI deleted the feature/add-msn-chat-plugin branch April 2, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants