Improve robustness of Sophos plugin #1083
Conversation
Schamper
left a comment
Schamper
left a comment
There was a problem hiding this comment.
Can you describe what is fixed in the PR description and add a unit test?
| _target=self.target, | ||
| ) | ||
| except Exception as error: | ||
| self.target.log.warning(f"Error: {error} on log line: {line}.") |
There was a problem hiding this comment.
| self.target.log.warning(f"Error: {error} on log line: {line}.") | |
| self.target.log.warning("Error: {error} on log line: {line}.") |
There was a problem hiding this comment.
That results in the following linting error:
dissect/target/plugins/apps/av/sophos.py:127:21: F841 local variable 'error' is assigned to but never used
Should I leave the format string?
There was a problem hiding this comment.
Make it a proper logging format string using %s and passing error as argument.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1083 +/- ##
=======================================
Coverage 79.26% 79.26%
=======================================
Files 348 348
Lines 31127 31133 +6
=======================================
+ Hits 24673 24679 +6
Misses 6454 6454
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Schamper
changed the title
2 participants
Add support for Sophos Home AV logs for version
3.9.4.1or earlier and verify if log files exist.