Skip to content

Conversation

@JSCU-CNI
Copy link
Contributor

This PR adds support for leap days in year_rollover_helper and generally makes the function more robust when encountering invalid dates.

@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.11%. Comparing base (c0cae58) to head (633e5e7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/helpers/utils.py 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1081      +/-   ##
==========================================
- Coverage   79.12%   79.11%   -0.01%     
==========================================
  Files         341      341              
  Lines       30176    30181       +5     
==========================================
+ Hits        23877    23878       +1     
- Misses       6299     6303       +4     
Flag Coverage Δ
unittests 79.11% <28.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That must've been fun to debug 😄.

@Schamper Schamper merged commit adda634 into fox-it:main Apr 1, 2025
18 of 22 checks passed
@JSCU-CNI JSCU-CNI deleted the fix/log-parsing-leap-days branch April 2, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants