Add Windows RDP bitmap cache plugin #1080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
#1082 might allow this to work on individual files. |
Schamper
requested changes
Apr 7, 2025
Co-authored-by: Erik Schamper <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
Files not reviewed (2)
- tests/_data/plugins/os/windows/rdpcache/Cache0000.bin: Language not supported
- tests/_data/plugins/os/windows/rdpcache/bcache24.bmc: Language not supported
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1080 +/- ##
==========================================
+ Coverage 79.27% 79.37% +0.09%
==========================================
Files 346 347 +1
Lines 30793 31004 +211
==========================================
+ Hits 24411 24608 +197
- Misses 6382 6396 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Schamper
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to recover bitmaps from the Windows RDP Bitmap Cache. We've based the plugin on bmc-tools. Unlike bmc-tools, this plugin does not support BMC files with a bits-per-pixel other than 32. Such files should be quite rare nowadays.
We did run into an existing problem: we cannot expose the parser easily so it can be run against separate
.binor.bmcfiles that do not reside in an already existing Target (as mentioned in issues such as #789).See the grid export below for example output of the
rdpcache.recoverplugin function.