Skip to content

Conversation

@JSCU-CNI
Copy link
Contributor

This PR improves plugin arguments and adds tests to make sure every plugin argument is defined more strict.

@JSCU-CNI JSCU-CNI requested a review from Schamper March 24, 2025 11:19
Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The required and type=str applies to everywhere but I didn't leave a comment on each one.

@Schamper
Copy link
Member

@JSCU-CNI what's the status on this one? Would be nice to have some "linting" for this in place.

@JSCU-CNI
Copy link
Contributor Author

@JSCU-CNI what's the status on this one? Would be nice to have some "linting" for this in place.

This one slipped through the cracks, will take a look today.

@JSCU-CNI JSCU-CNI requested a review from Schamper April 29, 2025 12:49
@JSCU-CNI JSCU-CNI requested a review from Schamper April 29, 2025 15:55
Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added some more checks.

@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 96.15385% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.86%. Comparing base (dc3e712) to head (f153cdc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/tools/fs.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1070   +/-   ##
=======================================
  Coverage   77.86%   77.86%           
=======================================
  Files         357      357           
  Lines       32435    32439    +4     
=======================================
+ Hits        25255    25259    +4     
  Misses       7180     7180           
Flag Coverage Δ
unittests 77.86% <96.15%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JSCU-CNI JSCU-CNI requested a review from Schamper April 30, 2025 14:19
@Schamper Schamper merged commit 81ff5f4 into fox-it:main May 1, 2025
21 of 24 checks passed
@JSCU-CNI JSCU-CNI deleted the improvement/plugin-arguments branch May 1, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants