-
Notifications
You must be signed in to change notification settings - Fork 71
Improve plugin arguments #1070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve plugin arguments #1070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The required and type=str applies to everywhere but I didn't leave a comment on each one.
|
@JSCU-CNI what's the status on this one? Would be nice to have some "linting" for this in place. |
This one slipped through the cracks, will take a look today. |
Co-authored-by: Erik Schamper <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also added some more checks.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1070 +/- ##
=======================================
Coverage 77.86% 77.86%
=======================================
Files 357 357
Lines 32435 32439 +4
=======================================
+ Hits 25255 25259 +4
Misses 7180 7180
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR improves plugin arguments and adds tests to make sure every plugin argument is defined more strict.