Skip to content

Conversation

@JSCU-CNI
Copy link
Contributor

This PR improves target-query's exception handling log messages. The previous log message used the variable func which is not correct.

@JSCU-CNI JSCU-CNI changed the title Improve target-query exception handling logging Improve target-query exception handling and logging Mar 11, 2025
@Schamper Schamper self-requested a review March 11, 2025 18:40
@JSCU-CNI JSCU-CNI requested a review from Schamper April 2, 2025 12:27
@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.28%. Comparing base (e58718e) to head (74c0946).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/tools/query.py 64.70% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1062      +/-   ##
==========================================
+ Coverage   79.24%   79.28%   +0.04%     
==========================================
  Files         345      345              
  Lines       30661    30664       +3     
==========================================
+ Hits        24297    24313      +16     
+ Misses       6364     6351      -13     
Flag Coverage Δ
unittests 79.28% <64.70%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Schamper Schamper merged commit faae71e into fox-it:main Apr 7, 2025
19 of 23 checks passed
@JSCU-CNI JSCU-CNI deleted the fix/query-exception-handling branch April 7, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants