Skip to content

Conversation

@JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Mar 4, 2025

This PR replaces empty evtx values "-" to None in format_value. We also have added some example Security.evtx logs in the tests.

@JSCU-CNI JSCU-CNI requested a review from Schamper March 19, 2025 12:55
@JSCU-CNI JSCU-CNI requested a review from Schamper March 24, 2025 10:19
@codecov
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.34%. Comparing base (fe3ca7d) to head (696af01).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/plugins/os/windows/log/evtx.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1058   +/-   ##
=======================================
  Coverage   79.33%   79.34%           
=======================================
  Files         347      347           
  Lines       31012    31023   +11     
=======================================
+ Hits        24604    24614   +10     
- Misses       6408     6409    +1     
Flag Coverage Δ
unittests 79.34% <93.75%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JSCU-CNI JSCU-CNI requested a review from Schamper April 7, 2025 12:31
@JSCU-CNI JSCU-CNI requested a review from Schamper April 7, 2025 13:01
@JSCU-CNI JSCU-CNI requested a review from Schamper April 7, 2025 15:04
@Schamper Schamper merged commit 3ff4dd5 into fox-it:main Apr 7, 2025
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants