Skip to content

Conversation

@JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Jun 16, 2025

This PR adds the reverse endianness of the SquashFS magic header to the squashfs_def definition.

This PR adds a NotImplementedError exception for big-endian 3.x or older SquashFS filesystems.

@JSCU-CNI JSCU-CNI changed the title Add CIGAM_SFHSAUQS Add warning for big-endian squashfs filesystems Jun 17, 2025
Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a unit test ;)

@JSCU-CNI
Copy link
Contributor Author

Could you enable LFS @Schamper? Currently unable to push.

@Schamper
Copy link
Member

Done.

@JSCU-CNI JSCU-CNI requested a review from Schamper June 18, 2025 10:47
@JSCU-CNI JSCU-CNI requested a review from Schamper June 18, 2025 11:16
@codecov
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.10%. Comparing base (0887fd2) to head (eec836f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   86.02%   86.10%   +0.07%     
==========================================
  Files           5        5              
  Lines         365      367       +2     
==========================================
+ Hits          314      316       +2     
  Misses         51       51              
Flag Coverage Δ
unittests 86.10% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Schamper Schamper merged commit bf660b6 into fox-it:main Jun 18, 2025
24 checks passed
@JSCU-CNI JSCU-CNI deleted the squashfs-magic branch June 18, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants