Add QNX filesystem implementation #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schamper
force-pushed
the
add-qnxfs
branch
4 times, most recently
from
fa36dd8 to
04558a1
Compare
There was a problem hiding this comment.
Copilot reviewed 22 out of 26 changed files in this pull request and generated no comments.
Files not reviewed (4)
- COPYRIGHT: Language not supported
- MANIFEST.in: Language not supported
- tests/_docs/Makefile: Language not supported
- tests/_docs/index.rst: Language not supported
Comments suppressed due to low confidence (1)
dissect/qnxfs/qnx6.py:72
- [nitpick] Consider applying the caching decorator directly to the inode method definition rather than reassigning it in the constructor. This change can improve clarity and avoid potential shadowing of the original method.
self.inode = lru_cache(1024)(self.inode)
Horofic
requested changes
Apr 14, 2025
Horofic
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.