Skip to content

Conversation

@pyrco
Copy link
Contributor

@pyrco pyrco commented Jul 19, 2024

No description provided.

@pyrco pyrco requested a review from Schamper July 19, 2024 12:27
@pyrco
Copy link
Contributor Author

pyrco commented Jul 19, 2024

This PR depends on fox-it/dissect.util#51

@codecov
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.21%. Comparing base (781b8e1) to head (e9af7dd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   88.26%   88.21%   -0.05%     
==========================================
  Files           6        6              
  Lines         733      730       -3     
==========================================
- Hits          647      644       -3     
  Misses         86       86              
Flag Coverage Δ
unittests 88.21% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pyrco pyrco force-pushed the move-lzo-lz4-selection-to-dissect.util branch from c6596f9 to d851e86 Compare July 25, 2024 14:30
@pyrco pyrco force-pushed the move-lzo-lz4-selection-to-dissect.util branch from d851e86 to b7238c0 Compare July 26, 2024 10:14
@pyrco pyrco requested a review from Schamper July 26, 2024 10:14
@pyrco pyrco force-pushed the move-lzo-lz4-selection-to-dissect.util branch 2 times, most recently from 2fdeec1 to 2e0484d Compare July 26, 2024 12:56
@pyrco pyrco requested a review from Schamper July 26, 2024 12:57
Schamper
Schamper previously approved these changes Jul 26, 2024
@pyrco pyrco force-pushed the move-lzo-lz4-selection-to-dissect.util branch from 2e0484d to e9af7dd Compare July 26, 2024 13:26
@pyrco pyrco requested a review from Schamper July 26, 2024 13:34
@pyrco pyrco merged commit 01cbab3 into main Jul 29, 2024
@pyrco pyrco deleted the move-lzo-lz4-selection-to-dissect.util branch July 29, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants