fix(verify): add timeout for runtime verification to prevent hanging #13295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The runtime verification phase of `forge verify-bytecode` could hang indefinitely when RPCs are slow or don't support historical state queries. Root cause: The fork provider was not using the `eth_rpc_timeout` from foundry.toml, and the default 8 retries meant a failing request could take 6+ minutes before timing out. Changes: - Add `fork_timeout` field to EvmOpts - Pass config timeout to fork provider in verify-bytecode - Limit retries to 2 for faster failure on unresponsive RPCs - Add 300s overall timeout as failsafe - Add trace logging to help identify hang points Fixes foundry-rs#13184
Ubuntu-Buddha
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
forge verify-bytecodehanging indefinitely during runtime verification when RPCs are slow or don't support historical state queries.Root cause: The fork provider wasn't using the
eth_rpc_timeoutfromfoundry.toml, and the default 8 retries at 45s each meant a single failing RPC call could take 6+ minutes.Changes:
fork_timeoutfield toEvmOptsto pass config timeout to fork providerfork_retries = 2for verify-bytecode to fail fast on unresponsive RPCsRelated Issue
Fixes #13184
Test Plan
cargo check -p forge-verify -p foundry-evm-corepassesforge verify-bytecodeagainst a CREATE2 contract with slow RPC - should timeout instead of hanging indefinitelyeth_rpc_timeoutinfoundry.tomlto adjust the timeout