refactor: simplify gas snapshot handling in cheatcodes #12605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sharilleed223
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
Sharilleed223
force-pushed
the
refactor/gas-snapshot-simplify-clean
branch
from
f3709b3 to
4de5e95
Compare
grandizzy
requested changes
Nov 19, 2025
Collaborator
grandizzy
left a comment
grandizzy
left a comment
There was a problem hiding this comment.
should work, please fix CI fmt
Sharilleed223
force-pushed
the
refactor/gas-snapshot-simplify-clean
branch
2 times, most recently
from
a406abd to
9d24699
Compare
Contributor
Author
|
Hi @grandizzy, did it, pls check, thanks! |
Sharilleed223
force-pushed
the
refactor/gas-snapshot-simplify-clean
branch
from
9d24699 to
7ca62c2
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
grandizzy
pushed a commit
that referenced
this pull request
Dec 19, 2025
grandizzy
added a commit
that referenced
this pull request
Dec 19, 2025
* fix: bump svm-rs (#12728) fix: bump svm-rs and builds * chore: update to macos14 runner (#12774) chore: macos14 runner * chore: fix clippy & forge-std external test (#12698) * chore: fix clippy * bump forge-std * bump solady to pick up fuzz test fix * refactor: simplify gas snapshot handling in cheatcodes (#12605) * chore(tests): bump forge-std version (#12661) * chore: bump forge-std version used for tests * bump ci * bump invariant.shrink_run_limit to 425 to give shrinker more opportunity to find minimum sequence --------- Co-authored-by: zerosnacks <[email protected]> Co-authored-by: zerosnacks <[email protected]> * fix(`ci`): ignore `number_prefix` is unmaintained in `cargo deny` (#12598) number_prefix is unmaintained * chore: disable failing test (#12620) * chore: bump version 1.5.1 (#12873) --------- Co-authored-by: Sharille Reed <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: zerosnacks <[email protected]> Co-authored-by: zerosnacks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify Option unwrapping patterns in gas snapshot handling: