-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat(fmt): add single_line_imports option to keep single imports on one line #12303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cd035af
add single_line_imports option to keep single imports on one line
silvekkk 3fb74a8
update readme
silvekkk 54de5e1
add tests for single_line_imports feature + fmt
silvekkk e8d7226
fix clippy and simplify the code
silvekkk 8b893ae
fix test failed
silvekkk 38e5628
fix: simplify
0xrusowsky 2f3899e
Merge branch 'master' into fmt
grandizzy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| // Test cases for single_line_imports configuration | ||
|
|
||
| // Single import that exceeds line length (121 chars) | ||
| import { | ||
| ITransparentUpgradeableProxy | ||
| } from "@openzeppelin/contracts/proxy/transparent/TransparentUpgradeableProxy.sol"; | ||
|
|
||
| // Single import with trailing comment | ||
| import {SomeContract} from "path/to/SomeContract.sol"; // This is a comment | ||
|
|
||
| // Single import with comment above | ||
| // This contract handles authentication | ||
| import {AuthManager} from "contracts/auth/AuthManager.sol"; | ||
|
|
||
| // Multiple imports should still wrap regardless of config | ||
| import { | ||
| Contract1, | ||
| Contract2, | ||
| Contract3, | ||
| Contract4 | ||
| } from "long/path/to/contracts.sol"; | ||
|
|
||
| // Short single import | ||
| import {Token} from "Token.sol"; | ||
|
|
||
| // Single import with alias | ||
| import {LongContractName as LCN} from "contracts/LongContractName.sol"; | ||
|
|
||
| // Mixed comment styles | ||
| import {MixedComment} from "Mixed.sol"; /* block comment */ // line comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| // Test cases for single_line_imports configuration | ||
|
|
||
| // Single import that exceeds line length (121 chars) | ||
| import { ITransparentUpgradeableProxy } from "@openzeppelin/contracts/proxy/transparent/TransparentUpgradeableProxy.sol"; | ||
|
|
||
| // Single import with trailing comment | ||
| import { SomeContract } from "path/to/SomeContract.sol"; // This is a comment | ||
|
|
||
| // Single import with comment above | ||
| // This contract handles authentication | ||
| import { AuthManager } from "contracts/auth/AuthManager.sol"; | ||
|
|
||
| // Multiple imports should still wrap regardless of config | ||
| import { Contract1, Contract2, Contract3, Contract4 } from "long/path/to/contracts.sol"; | ||
|
|
||
| // Short single import | ||
| import { Token } from "Token.sol"; | ||
|
|
||
| // Single import with alias | ||
| import { LongContractName as LCN } from "contracts/LongContractName.sol"; | ||
|
|
||
| // Mixed comment styles | ||
| import { MixedComment } from "Mixed.sol"; /* block comment */ // line comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // config: single_line_imports = true | ||
| // Test cases for single_line_imports configuration | ||
|
|
||
| // Single import that exceeds line length (121 chars) | ||
| import {ITransparentUpgradeableProxy} from "@openzeppelin/contracts/proxy/transparent/TransparentUpgradeableProxy.sol"; | ||
|
|
||
| // Single import with trailing comment | ||
| import {SomeContract} from "path/to/SomeContract.sol"; // This is a comment | ||
|
|
||
| // Single import with comment above | ||
| // This contract handles authentication | ||
| import {AuthManager} from "contracts/auth/AuthManager.sol"; | ||
|
|
||
| // Multiple imports should still wrap regardless of config | ||
| import { | ||
| Contract1, | ||
| Contract2, | ||
| Contract3, | ||
| Contract4 | ||
| } from "long/path/to/contracts.sol"; | ||
|
|
||
| // Short single import | ||
| import {Token} from "Token.sol"; | ||
|
|
||
| // Single import with alias | ||
| import {LongContractName as LCN} from "contracts/LongContractName.sol"; | ||
|
|
||
| // Mixed comment styles | ||
| import {MixedComment} from "Mixed.sol"; /* block comment */ // line comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.