Skip to content

Update yansi to 1.0#107

Merged
DaniPopes merged 2 commits intofoundry-rs:mainfrom
dcb9:updateYansi
Apr 19, 2024
Merged

Update yansi to 1.0#107
DaniPopes merged 2 commits intofoundry-rs:mainfrom
dcb9:updateYansi

Conversation

@dcb9
Copy link

@dcb9 dcb9 commented Apr 19, 2024

@dcb9 dcb9 requested review from DaniPopes and Evalir as code owners April 19, 2024 11:21
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at some docs

// The following two are equivalent. The latter is preferred.
static DEBUG_A: Style = Yellow.foreground().bold();
static DEBUG_B: Style = Yellow.bold();

looks like we don't need the foreground call?

@dcb9
Copy link
Author

dcb9 commented Apr 19, 2024

removed foreground call.

Style::new().fg(Yellow) and Yellow.foreground() are equivalent, now I choose the first style, which one do you prefer?

Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DaniPopes DaniPopes merged commit c9d421e into foundry-rs:main Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants