Conversation
mattsse
reviewed
Jul 10, 2024
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
we can add this to the enum because solc already has support for this
but we can't add it to normalize_version_solc yet because we don't know the version yet and 0.8.26 is incorrect I believe because that's the latest release:
https://github.com/ethereum/solidity/releases/tag/v0.8.26
Contributor
good catch, I see in solidity's repo that the |
klkvr
force-pushed
the
rakita/prague_spec
branch
from
69cc744 to
d01269f
Compare
DaniPopes
reviewed
Jul 26, 2024
DaniPopes
approved these changes
Jul 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Prague spec.
TODO: PragueEOF support is needed.