Merged
Conversation
cameel
reviewed
May 27, 2024
Collaborator
cameel
left a comment
There was a problem hiding this comment.
Still missing in two places:
- List of EVM versions in "Using the compiler".
- Also the
evmVersionfield there has a comment with possible values.
- Also the
test/tools/fuzzer_common.cpp,test/tools/ossfuzz/yulProto.protoandtest/tools/ossfuzz/protoToYul.cpp(unless we're leaving it up to @bshastry)
cameel
reviewed
May 27, 2024
Contributor
@bshastry typically handles this on the fuzzer side. |
cameel
reviewed
May 27, 2024
Collaborator
True, but these are simple enough that it would not hurt if we already added them here. But anyway, mentioning it mostly for completeness. |
9aa33c8 to
11eebaa
Compare
r0qs
previously approved these changes
May 28, 2024
cameel
reviewed
May 28, 2024
cameel
approved these changes
May 28, 2024
Collaborator
|
Needs squashing and then it's fine to merge. |
562dd6b to
85396f4
Compare
nikola-matic
approved these changes
May 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #15111.