Skip to content

Introduce EVM version prague#15152

Merged
nikola-matic merged 1 commit intodevelopfrom
introduce-evm-version-prague
May 29, 2024
Merged

Introduce EVM version prague#15152
nikola-matic merged 1 commit intodevelopfrom
introduce-evm-version-prague

Conversation

@matheusaaguiar
Copy link
Contributor

closes #15111.

@matheusaaguiar matheusaaguiar self-assigned this May 27, 2024
Copy link
Collaborator

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing in two places:

  • List of EVM versions in "Using the compiler".
    • Also the evmVersion field there has a comment with possible values.
  • test/tools/fuzzer_common.cpp, test/tools/ossfuzz/yulProto.proto and test/tools/ossfuzz/protoToYul.cpp (unless we're leaving it up to @bshastry)

@nikola-matic
Copy link
Contributor

Still missing in two places:

* List of EVM versions in "Using the compiler".
  
  * Also the `evmVersion` field there has a comment with possible values.

* `test/tools/fuzzer_common.cpp`, `test/tools/ossfuzz/yulProto.proto` and `test/tools/ossfuzz/protoToYul.cpp` (unless we're leaving it up to @bshastry)

@bshastry typically handles this on the fuzzer side.

@cameel
Copy link
Collaborator

cameel commented May 27, 2024

@bshastry typically handles this on the fuzzer side.

True, but these are simple enough that it would not hurt if we already added them here. But anyway, mentioning it mostly for completeness.

@matheusaaguiar matheusaaguiar force-pushed the introduce-evm-version-prague branch from 9aa33c8 to 11eebaa Compare May 28, 2024 14:04
r0qs
r0qs previously approved these changes May 28, 2024
@cameel
Copy link
Collaborator

cameel commented May 28, 2024

Needs squashing and then it's fine to merge.

@matheusaaguiar matheusaaguiar force-pushed the introduce-evm-version-prague branch from 562dd6b to 85396f4 Compare May 28, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Add EVM Version Prague

4 participants