Skip to content

Fix: update Twitter icon to X branding for official FOSSASIA links #102

Open
radhishmahajan wants to merge 3 commits intofossasia:masterfrom
radhishmahajan:fix-twitter-icon
Open

Fix: update Twitter icon to X branding for official FOSSASIA links #102
radhishmahajan wants to merge 3 commits intofossasia:masterfrom
radhishmahajan:fix-twitter-icon

Conversation

@radhishmahajan
Copy link

@radhishmahajan radhishmahajan commented Feb 14, 2026

  • Included a Preview link and screenshot showing after and before the changes.
  • Included a description of the change below.
  • Squashed the commits.

Changes done in this Pull Request

Screenshot 2026-02-15 000134 Screenshot 2026-02-15 000159

Description / Changes

This PR updates the Twitter icon to reflect the new "X" branding for the official FOSSASIA social media links.

The previous Twitter font icon has been replaced with the official X SVG logo to ensure accurate branding and better visual consistency.

The changes are limited only to the official FOSSASIA Twitter links in the main social sections (header/footer). Speaker profile links and metadata have not been modified, as they are outside the scope of this issue.

No third-party icon libraries were modified.

Screenshots if any:

Before:

The official social section displayed the old Twitter bird icon.

After:

The official social section now displays the updated X branding logo.

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 14, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the FOSSASIA official Twitter social links in key HTML pages to use an "X" text-based representation instead of the old Twitter bird icon, limited to the main social sections only.

File-Level Changes

Change Details Files
Replace the Twitter bird icon with an "X" text label for official FOSSASIA Twitter links in main social sections.
  • Update the 404 page social bar Twitter entry to render a bold "X" instead of the social_twitter icon element.
  • Update the 500 page social bar Twitter entry to render a bold "X" instead of the social_twitter icon element.
  • Update the primary index page header social links to show a bold "X" for the Twitter link instead of the social_twitter icon.
404.html
500.html
index1.html

Assessment against linked issues

Issue Objective Addressed Explanation
#99 Replace the old Twitter bird icon with the new X branding for the Twitter link in the site footer (and related main social sections).
#99 Keep styling of the updated X icon consistent with the existing social icons in the footer. The PR replaces the icon element <i class="icon social_twitter"></i> with a bold text span <span style="font-weight:bold;">X</span>, while the other social links still use icon font classes (e.g., social_facebook, social_youtube). This is likely to result in a visually different style and alignment compared to the other social icons, so styling consistency is not maintained.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In 404.html the updated link markup has a typo (<<span ...>) which will render invalid HTML; drop the extra < so the span is parsed correctly.
  • Instead of inlining a bold X text node, consider using a reusable CSS class or icon (e.g., replacing social_twitter with a new social_x class) so the social icons remain visually consistent and easier to adjust across the site.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In 404.html the updated link markup has a typo (`<<span ...>`) which will render invalid HTML; drop the extra `<` so the span is parsed correctly.
- Instead of inlining a bold `X` text node, consider using a reusable CSS class or icon (e.g., replacing `social_twitter` with a new `social_x` class) so the social icons remain visually consistent and easier to adjust across the site.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@radhishmahajan radhishmahajan deleted the fix-twitter-icon branch February 14, 2026 13:06
@radhishmahajan radhishmahajan restored the fix-twitter-icon branch February 14, 2026 13:08
@radhishmahajan
Copy link
Author

Thank you for the feedback.

I have corrected the typo in 404.html and replaced the inline styling with a reusable social_x CSS class to keep the implementation consistent with the existing icon structure.

Please let me know if any further improvements are needed.

@radhishmahajan
Copy link
Author

i had updated the code with svg for more correct and exact icon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Twitter icon to X branding in footer

1 participant