Fix: update Twitter icon to X branding for official FOSSASIA links #102
Open
radhishmahajan wants to merge 3 commits intofossasia:masterfrom
Open
Fix: update Twitter icon to X branding for official FOSSASIA links #102radhishmahajan wants to merge 3 commits intofossasia:masterfrom
radhishmahajan wants to merge 3 commits intofossasia:masterfrom
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the FOSSASIA official Twitter social links in key HTML pages to use an "X" text-based representation instead of the old Twitter bird icon, limited to the main social sections only. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In 404.html the updated link markup has a typo (
<<span ...>) which will render invalid HTML; drop the extra<so the span is parsed correctly. - Instead of inlining a bold
Xtext node, consider using a reusable CSS class or icon (e.g., replacingsocial_twitterwith a newsocial_xclass) so the social icons remain visually consistent and easier to adjust across the site.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In 404.html the updated link markup has a typo (`<<span ...>`) which will render invalid HTML; drop the extra `<` so the span is parsed correctly.
- Instead of inlining a bold `X` text node, consider using a reusable CSS class or icon (e.g., replacing `social_twitter` with a new `social_x` class) so the social icons remain visually consistent and easier to adjust across the site.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Author
|
Thank you for the feedback. I have corrected the typo in 404.html and replaced the inline styling with a reusable Please let me know if any further improvements are needed. |
Author
|
i had updated the code with svg for more correct and exact icon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes done in this Pull Request
Description / Changes
This PR updates the Twitter icon to reflect the new "X" branding for the official FOSSASIA social media links.
The previous Twitter font icon has been replaced with the official X SVG logo to ensure accurate branding and better visual consistency.
The changes are limited only to the official FOSSASIA Twitter links in the main social sections (header/footer). Speaker profile links and metadata have not been modified, as they are outside the scope of this issue.
No third-party icon libraries were modified.
Screenshots if any:
Before:
The official social section displayed the old Twitter bird icon.
After:
The official social section now displays the updated X branding logo.