Skip to content

fix: hide hamburger menu on desktop view#907

Open
Ramprasadlondhe2005 wants to merge 2 commits intofossasia:gh-pagesfrom
Ramprasadlondhe2005:fix-hide-hamburger-desktop
Open

fix: hide hamburger menu on desktop view#907
Ramprasadlondhe2005 wants to merge 2 commits intofossasia:gh-pagesfrom
Ramprasadlondhe2005:fix-hide-hamburger-desktop

Conversation

@Ramprasadlondhe2005
Copy link

@Ramprasadlondhe2005 Ramprasadlondhe2005 commented Jan 12, 2026

What does this PR do?

This PR fixes multiple UI issues related to navigation and social icons.

Fixes

Screenshots

Before

  • Twitter bird icon used in social links
Screenshot 2026-01-12 204339
  • Hamburger menu visible on desktop view
image

After

  • Official X logo with correct size and color across all sections
Screenshot 2026-01-13 003607 Screenshot 2026-01-13 003645 Screenshot 2026-01-13 003712 Screenshot 2026-01-13 011324
  • Hamburger menu hidden on desktop view
image

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 12, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a responsive CSS rule to hide the hamburger menu toggle icons on desktop-sized viewports (≥1024px) while keeping them visible on smaller/mobile screens.

Flow diagram for responsive hamburger menu visibility

flowchart TD
  A[Check viewport width] --> B{Is viewport width >= 1024px?}
  B -- Yes --> C[Apply CSS: .sidebar-menu-toggle display none important]
  B -- Yes --> D[Apply CSS: .mobile-menu-toggle display none important]
  B -- No --> E[No override: toggles remain visible based on base styles]
  C --> F[Hamburger menu hidden on desktop]
  D --> F
  E --> G[Hamburger menu visible on mobile and small screens]
Loading

File-Level Changes

Change Details Files
Hide mobile and sidebar hamburger menu toggles on desktop viewports via a new media query.
  • Introduce a min-width: 1024px media query block at the end of the theme stylesheet.
  • Within this desktop media query, set .sidebar-menu-toggle and .mobile-menu-toggle to display: none with !important to override existing styles.
css/theme-lava.css

Assessment against linked issues

Issue Objective Addressed Explanation
#904 Ensure the hamburger menu icons (.mobile-menu-toggle and any related toggles) are hidden on desktop/laptop viewports (≥1024px) while remaining visible on mobile (<1024px).

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider avoiding !important on the .sidebar-menu-toggle and .mobile-menu-toggle rules if possible by increasing selector specificity or restructuring the CSS, so future overrides remain manageable.
  • Double-check that the @media (min-width: 1024px) breakpoint aligns with the existing layout breakpoints in the project so the hamburger visibility matches the rest of the responsive design.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider avoiding `!important` on the `.sidebar-menu-toggle` and `.mobile-menu-toggle` rules if possible by increasing selector specificity or restructuring the CSS, so future overrides remain manageable.
- Double-check that the `@media (min-width: 1024px)` breakpoint aligns with the existing layout breakpoints in the project so the hamburger visibility matches the rest of the responsive design.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Ramprasadlondhe2005
Copy link
Author

Thanks for the review and suggestions!
I’ve checked the existing breakpoints in the project and 1024px aligns with the current responsive behavior.

Regarding !important, it was added to safely override existing theme styles, but I’m happy to update it if maintainers prefer a different approach.
Please let me know how you’d like me to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Twitter icons to official X logo across fossasia.org website Hamburger menu should be hidden on desktop view

1 participant