Skip to content

Replaces /control with /common for issue 1877 of eventyay#17

Open
ViRUS-0-0 wants to merge 1 commit intofossasia:masterfrom
ViRUS-0-0:eventyay-issue-1877
Open

Replaces /control with /common for issue 1877 of eventyay#17
ViRUS-0-0 wants to merge 1 commit intofossasia:masterfrom
ViRUS-0-0:eventyay-issue-1877

Conversation

@ViRUS-0-0
Copy link

@ViRUS-0-0 ViRUS-0-0 commented Jan 22, 2026

Fixes admin mode organizer.edit error in eventyay.

Error Screenshot :
Screenshot 2026-01-22 at 9 56 58 PM

Stacktrace :
Screenshot 2026-01-22 at 9 59 14 PM

Reference of comment : LINK
Reference of issue : #1877
Reference of PR : #1961

Summary by Sourcery

Update Stripe plugin organizer settings routes to use the shared /common organizer namespace instead of the deprecated /control namespace.

Bug Fixes:

  • Fix admin organizer settings navigation by pointing the parent link to the common organizer edit route.
  • Align the Stripe organizer settings URL pattern with the common organizer route to prevent organizer.edit errors in admin mode.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 22, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates Stripe plugin organizer settings navigation and URL routing to use the new /common organizer base and the eventyay_common organizer edit route, fixing the admin mode organizer.edit error.

Sequence diagram for updated Stripe organizer settings routing and parent navigation

sequenceDiagram
  actor Admin
  participant Browser
  participant Django_URLConf as Django_URLConf
  participant Stripe_nav_signal as Stripe_nav_signal
  participant OrganizerSettingsFormView as OrganizerSettingsFormView

  Admin->>Browser: Click organizer_edit in admin mode
  Browser->>Django_URLConf: GET /common/organizer/{organizer}/edit/
  Django_URLConf->>Stripe_nav_signal: Emit nav_o with organizer and request
  Stripe_nav_signal->>Stripe_nav_signal: Build menu item
  Stripe_nav_signal->>Django_URLConf: Parent URL reverse eventyay_common:organizer.edit
  Stripe_nav_signal->>Django_URLConf: Child URL reverse plugins:eventyay_stripe:settings.connect
  Admin->>Browser: Click Stripe_connect_settings menu item
  Browser->>Django_URLConf: GET /common/organizer/{organizer}/stripeconnect/
  Django_URLConf->>OrganizerSettingsFormView: Dispatch request
  OrganizerSettingsFormView-->>Browser: Render Stripe organizer settings page
Loading

File-Level Changes

Change Details Files
Update parent navigation link for Stripe organizer settings to use the new common organizer edit view.
  • Change Django reverse() namespace for the organizer edit view from the old control app to the eventyay_common app.
  • Ensure the parent navigation for the Stripe settings menu item correctly targets the organizer.edit route under the new namespace.
eventyay_stripe/signals.py
Align Stripe organizer settings URL pattern with the new /common organizer path.
  • Change the organizer settings re_path prefix from /control/organizer/... to /common/organizer/... to match the updated routing scheme.
  • Keep the view (OrganizerSettingsFormView) and URL name (settings.connect) unchanged so existing reverse calls continue to work.
eventyay_stripe/urls.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The OrganizerSettingsFormView URL was moved from /control/organizer/... to /common/organizer/... but the disconnect URL remains under /control/event/...; please confirm this asymmetry is intentional and aligns with how the rest of the organizer/event routes are structured.
  • In nav_o, you switched the parent to reverse('eventyay_common:organizer.edit', ...) while the plugin URL pattern hardcodes ^common/organizer/...; consider reusing the same named route or URL pattern convention the core app uses so that path/namespace stay in sync and avoid future breakage if the base path changes again.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `OrganizerSettingsFormView` URL was moved from `/control/organizer/...` to `/common/organizer/...` but the disconnect URL remains under `/control/event/...`; please confirm this asymmetry is intentional and aligns with how the rest of the organizer/event routes are structured.
- In `nav_o`, you switched the parent to `reverse('eventyay_common:organizer.edit', ...)` while the plugin URL pattern hardcodes `^common/organizer/...`; consider reusing the same named route or URL pattern convention the core app uses so that path/namespace stay in sync and avoid future breakage if the base path changes again.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an admin mode error in the eventyay Stripe plugin by updating the organizer settings routes from the deprecated /control namespace to the new /common namespace, aligning with the migration described in issue #1877 and PR #1961.

Changes:

  • Updated organizer settings URL pattern from /control/organizer/ to /common/organizer/
  • Updated navigation parent link reference from control:organizer.edit to eventyay_common:organizer.edit

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
eventyay_stripe/urls.py Updated URL pattern for organizer Stripe Connect settings to use /common/organizer/ instead of /control/organizer/
eventyay_stripe/signals.py Updated parent navigation link to reference eventyay_common:organizer.edit instead of control:organizer.edit

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ViRUS-0-0
Copy link
Author

ViRUS-0-0 commented Jan 30, 2026

Hey @mariobehling, @Sak1012, Could you please review this also? (Reference #1961 and comment-link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant