Replaces /control with /common for issue 1877 of eventyay#17
Replaces /control with /common for issue 1877 of eventyay#17ViRUS-0-0 wants to merge 1 commit intofossasia:masterfrom
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates Stripe plugin organizer settings navigation and URL routing to use the new /common organizer base and the eventyay_common organizer edit route, fixing the admin mode organizer.edit error. Sequence diagram for updated Stripe organizer settings routing and parent navigationsequenceDiagram
actor Admin
participant Browser
participant Django_URLConf as Django_URLConf
participant Stripe_nav_signal as Stripe_nav_signal
participant OrganizerSettingsFormView as OrganizerSettingsFormView
Admin->>Browser: Click organizer_edit in admin mode
Browser->>Django_URLConf: GET /common/organizer/{organizer}/edit/
Django_URLConf->>Stripe_nav_signal: Emit nav_o with organizer and request
Stripe_nav_signal->>Stripe_nav_signal: Build menu item
Stripe_nav_signal->>Django_URLConf: Parent URL reverse eventyay_common:organizer.edit
Stripe_nav_signal->>Django_URLConf: Child URL reverse plugins:eventyay_stripe:settings.connect
Admin->>Browser: Click Stripe_connect_settings menu item
Browser->>Django_URLConf: GET /common/organizer/{organizer}/stripeconnect/
Django_URLConf->>OrganizerSettingsFormView: Dispatch request
OrganizerSettingsFormView-->>Browser: Render Stripe organizer settings page
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
OrganizerSettingsFormViewURL was moved from/control/organizer/...to/common/organizer/...but the disconnect URL remains under/control/event/...; please confirm this asymmetry is intentional and aligns with how the rest of the organizer/event routes are structured. - In
nav_o, you switched the parent toreverse('eventyay_common:organizer.edit', ...)while the plugin URL pattern hardcodes^common/organizer/...; consider reusing the same named route or URL pattern convention the core app uses so that path/namespace stay in sync and avoid future breakage if the base path changes again.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `OrganizerSettingsFormView` URL was moved from `/control/organizer/...` to `/common/organizer/...` but the disconnect URL remains under `/control/event/...`; please confirm this asymmetry is intentional and aligns with how the rest of the organizer/event routes are structured.
- In `nav_o`, you switched the parent to `reverse('eventyay_common:organizer.edit', ...)` while the plugin URL pattern hardcodes `^common/organizer/...`; consider reusing the same named route or URL pattern convention the core app uses so that path/namespace stay in sync and avoid future breakage if the base path changes again.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
This PR fixes an admin mode error in the eventyay Stripe plugin by updating the organizer settings routes from the deprecated /control namespace to the new /common namespace, aligning with the migration described in issue #1877 and PR #1961.
Changes:
- Updated organizer settings URL pattern from
/control/organizer/to/common/organizer/ - Updated navigation parent link reference from
control:organizer.edittoeventyay_common:organizer.edit
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eventyay_stripe/urls.py | Updated URL pattern for organizer Stripe Connect settings to use /common/organizer/ instead of /control/organizer/ |
| eventyay_stripe/signals.py | Updated parent navigation link to reference eventyay_common:organizer.edit instead of control:organizer.edit |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hey @mariobehling, @Sak1012, Could you please review this also? (Reference #1961 and comment-link) |
Fixes admin mode
organizer.editerror in eventyay.Error Screenshot :

Stacktrace :

Reference of comment : LINK
Reference of issue : #1877
Reference of PR : #1961
Summary by Sourcery
Update Stripe plugin organizer settings routes to use the shared /common organizer namespace instead of the deprecated /control namespace.
Bug Fixes: