Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRenames the plugin/package from 'exhibitors' to 'eventyay_exhibition' across CI workflows, packaging configuration, and localization tooling paths to reflect the new project identity. Flow diagram for localization tooling after rename to eventyay_exhibitionflowchart LR
A["Developer updates translations"] --> B["Run .update-locales.sh"]
B --> C["Use Weblate client wlc"]
C --> D["Fetch translations from component eventyay/eventyay-exhibition"]
D --> E["Write .po files into eventyay_exhibition/locale"]
E --> F["Run make localecompile"]
F --> G["Makefile discovers languages in eventyay_exhibition/locale"]
G --> H["django-admin compilemessages"]
H --> I["Compiled message files stored under eventyay_exhibition/locale"]
I --> J["eventyay_exhibition package uses updated translations"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 2 issues, and left some high level feedback:
- The GitHub Actions job name
Exhibitors Plugin Testsstill uses the old plugin name; consider renaming it to keep CI labels consistent with the neweventyay_exhibitionname. - Now that the package has been renamed to
eventyay-exhibition, review the README and any user-facing strings (e.g., description inpyproject.toml) to ensure they consistently use the new plugin name where appropriate.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The GitHub Actions job name `Exhibitors Plugin Tests` still uses the old plugin name; consider renaming it to keep CI labels consistent with the new `eventyay_exhibition` name.
- Now that the package has been renamed to `eventyay-exhibition`, review the README and any user-facing strings (e.g., description in `pyproject.toml`) to ensure they consistently use the new plugin name where appropriate.
## Individual Comments
### Comment 1
<location> `README.rst:6` </location>
<code_context>
-This is a plugin for `eventyay-tickets`_.
+This is a plugin for `eventyay`_.
This plugin enables to add and control exhibitors in eventyay
</code_context>
<issue_to_address>
**suggestion (typo):** Consider rephrasing this sentence to fix the grammatical issue.
The phrase "This plugin enables to add and control exhibitors in eventyay" is grammatically incorrect. Please rephrase, e.g. "This plugin enables you to add and control exhibitors in eventyay" for better readability.
```suggestion
This plugin enables you to add and control exhibitors in eventyay
```
</issue_to_address>
### Comment 2
<location> `README.rst:13` </location>
<code_context>
1. Make sure that you have a working `eventyay-tickets development setup`_.
-2. Clone this repository, eg to ``local/exhibitors``.
+2. Clone this repository, eg to ``local/eventyay-exhibition``.
3. Activate the virtual environment you use for eventyay-tickets development.
</code_context>
<issue_to_address>
**nitpick (typo):** Use the standard "e.g.," instead of "eg".
Please update "eg" to the standard "e.g.," in this sentence.
```suggestion
2. Clone this repository, e.g., to ``local/eventyay-exhibition``.
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Test failures due to missing Redis serviceProblemThe tests are failing because Redis is not running. but the connection is refused. Root causeThe GitHub Actions workflow defines a PostgreSQL service, but no Redis service is configured. The application depends on Redis for caching and or session management, so tests fail when Redis is unavailable. FixAdd a Redis service to the GitHub Actions workflow file: Place the Redis service right after the PostgreSQL service definition (for example, after line 30 in the current workflow). Updated services configurationservices:
postgres:
image: postgres:15
env:
POSTGRES_PASSWORD: postgres
POSTGRES_DB: eventyay-db
options: >-
--health-cmd pg_isready
--health-interval 10s
--health-timeout 5s
--health-retries 5
ports:
- 5432:5432
redis:
image: redis:7
options: >-
--health-cmd "redis-cli ping"
--health-interval 10s
--health-timeout 5s
--health-retries 5
ports:
- 6379:6379Environment variables for test executionIf the application relies on explicit Redis configuration, add the following environment variables to the Run tests step: - name: Run tests
env:
EVY_RUNNING_ENVIRONMENT: testing
EVY_POSTGRES_HOST: localhost
EVY_POSTGRES_PORT: 5432
EVY_POSTGRES_USER: postgres
EVY_POSTGRES_PASSWORD: postgres
EVY_POSTGRES_DB: eventyay-db
EVY_REDIS_HOST: localhost
EVY_REDIS_PORT: 6379
run: |
source venv/bin/activate
pytest tests --reruns 3ResultThis starts a Redis container alongside PostgreSQL in GitHub Actions, allowing the application to connect to Redis and the test suite to run successfully. |
Summary by Sourcery
Rename the exhibitors plugin to eventyay_exhibition across configuration, build metadata, and CI workflows.
Build:
CI:
Chores: