Skip to content

rename exhibitor to eventyay_exhibition#19

Open
norbusan wants to merge 10 commits intomainfrom
rename-plugin
Open

rename exhibitor to eventyay_exhibition#19
norbusan wants to merge 10 commits intomainfrom
rename-plugin

Conversation

@norbusan
Copy link
Member

@norbusan norbusan commented Feb 4, 2026

Summary by Sourcery

Rename the exhibitors plugin to eventyay_exhibition across configuration, build metadata, and CI workflows.

Build:

  • Update pyproject metadata, package name, and package discovery to use the eventyay_exhibition naming and repository URL.

CI:

  • Adjust style and test GitHub workflows to reference eventyay_exhibition paths and plugin name instead of exhibitors.

Chores:

  • Update locale management scripts and Makefile paths to use the new eventyay_exhibition directory structure.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 4, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Renames the plugin/package from 'exhibitors' to 'eventyay_exhibition' across CI workflows, packaging configuration, and localization tooling paths to reflect the new project identity.

Flow diagram for localization tooling after rename to eventyay_exhibition

flowchart LR
    A["Developer updates translations"] --> B["Run .update-locales.sh"]
    B --> C["Use Weblate client wlc"]
    C --> D["Fetch translations from component eventyay/eventyay-exhibition"]
    D --> E["Write .po files into eventyay_exhibition/locale"]
    E --> F["Run make localecompile"]
    F --> G["Makefile discovers languages in eventyay_exhibition/locale"]
    G --> H["django-admin compilemessages"]
    H --> I["Compiled message files stored under eventyay_exhibition/locale"]
    I --> J["eventyay_exhibition package uses updated translations"]
Loading

File-Level Changes

Change Details Files
Update GitHub Actions workflows to use the new plugin directory and package name for paths, labels, and checkout/install steps.
  • Adjust style workflow path ignores to reference eventyay_exhibition locale and static directories.
  • Update tests workflow path ignores to the new locale directory path.
  • Rename the test job checkout step label to reference eventyay_exhibition.
  • Change the test setup step to cd into ../eventyay-exhibition instead of the old plugin directory name.
.github/workflows/style.yml
.github/workflows/tests.yml
Rename the Python package/project metadata from 'exhibitors' to 'eventyay-exhibition' and align package discovery and dynamic version attribute with the new module name.
  • Change the project name field to eventyay-exhibition.
  • Update homepage URL to the new GitHub repository path.
  • Point dynamic version attribute to eventyay_exhibition.version.
  • Adjust setuptools package discovery include pattern to eventyay_exhibition*.
pyproject.toml
Update localization and build tooling to use the new component and directory names.
  • Change Weblate component identifier and locale directory path to eventyay_exhibition.
  • Update Makefile language discovery path to the new locale directory.
.update-locales.sh
Makefile
Adjust remaining repository metadata and lockfile to reflect the rename.
  • Ensure MANIFEST and README align with the new project naming (details in diff).
  • Update uv.lock to reflect new package name and any related dependency metadata.
MANIFEST.in
README.rst
uv.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 2 issues, and left some high level feedback:

  • The GitHub Actions job name Exhibitors Plugin Tests still uses the old plugin name; consider renaming it to keep CI labels consistent with the new eventyay_exhibition name.
  • Now that the package has been renamed to eventyay-exhibition, review the README and any user-facing strings (e.g., description in pyproject.toml) to ensure they consistently use the new plugin name where appropriate.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The GitHub Actions job name `Exhibitors Plugin Tests` still uses the old plugin name; consider renaming it to keep CI labels consistent with the new `eventyay_exhibition` name.
- Now that the package has been renamed to `eventyay-exhibition`, review the README and any user-facing strings (e.g., description in `pyproject.toml`) to ensure they consistently use the new plugin name where appropriate.

## Individual Comments

### Comment 1
<location> `README.rst:6` </location>
<code_context>
-This is a plugin for `eventyay-tickets`_. 
+This is a plugin for `eventyay`_. 

 This plugin enables to add and control exhibitors in eventyay

</code_context>

<issue_to_address>
**suggestion (typo):** Consider rephrasing this sentence to fix the grammatical issue.

The phrase "This plugin enables to add and control exhibitors in eventyay" is grammatically incorrect. Please rephrase, e.g. "This plugin enables you to add and control exhibitors in eventyay" for better readability.

```suggestion
This plugin enables you to add and control exhibitors in eventyay
```
</issue_to_address>

### Comment 2
<location> `README.rst:13` </location>
<code_context>
 1. Make sure that you have a working `eventyay-tickets development setup`_.

-2. Clone this repository, eg to ``local/exhibitors``.
+2. Clone this repository, eg to ``local/eventyay-exhibition``.

 3. Activate the virtual environment you use for eventyay-tickets development.
</code_context>

<issue_to_address>
**nitpick (typo):** Use the standard "e.g.," instead of "eg".

Please update "eg" to the standard "e.g.," in this sentence.

```suggestion
2. Clone this repository, e.g., to ``local/eventyay-exhibition``.
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

mariobehling and others added 3 commits February 4, 2026 11:27
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@mariobehling mariobehling enabled auto-merge (squash) February 4, 2026 10:29
@mariobehling
Copy link
Member

mariobehling commented Feb 4, 2026

Test failures due to missing Redis service

Problem

The tests are failing because Redis is not running.
During test execution, the application tries to connect to Redis at:


localhost:6379

but the connection is refused.

Root cause

The GitHub Actions workflow defines a PostgreSQL service, but no Redis service is configured.

The application depends on Redis for caching and or session management, so tests fail when Redis is unavailable.

Fix

Add a Redis service to the GitHub Actions workflow file:


.github/workflows/tests.yml

Place the Redis service right after the PostgreSQL service definition (for example, after line 30 in the current workflow).

Updated services configuration

services:
  postgres:
    image: postgres:15
    env:
      POSTGRES_PASSWORD: postgres
      POSTGRES_DB: eventyay-db
    options: >-
      --health-cmd pg_isready
      --health-interval 10s
      --health-timeout 5s
      --health-retries 5
    ports:
      - 5432:5432

  redis:
    image: redis:7
    options: >-
      --health-cmd "redis-cli ping"
      --health-interval 10s
      --health-timeout 5s
      --health-retries 5
    ports:
      - 6379:6379

Environment variables for test execution

If the application relies on explicit Redis configuration, add the following environment variables to the Run tests step:

- name: Run tests
  env:
    EVY_RUNNING_ENVIRONMENT: testing
    EVY_POSTGRES_HOST: localhost
    EVY_POSTGRES_PORT: 5432
    EVY_POSTGRES_USER: postgres
    EVY_POSTGRES_PASSWORD: postgres
    EVY_POSTGRES_DB: eventyay-db
    EVY_REDIS_HOST: localhost
    EVY_REDIS_PORT: 6379
  run: |
    source venv/bin/activate
    pytest tests --reruns 3

Result

This starts a Redis container alongside PostgreSQL in GitHub Actions, allowing the application to connect to Redis and the test suite to run successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants