Merged
Conversation
spatten
approved these changes
Jun 13, 2023
Contributor
spatten
left a comment
There was a problem hiding this comment.
I think you'll have to fix up the changelog because of the 3.8.1 release, but other than that this looks great
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Defaults
poetrydependencies to themaincategory when categories are not present.According to the poetry project, this is the default behavior in poetry: python-poetry/poetry#7637
Acceptance criteria
Poetry environments using newer versions of poetry no longer fail analysis.
Testing plan
I updated our automated test for the lock file. Additionally, I ran the following manual test.
I created a poetry project:
With changes:
Risks
None, this is mirroring what Poetry does so it's what Poetry devs will expect to see.
References
https://fossa.zendesk.com/agent/tickets/6362
Checklist
docs/.Changelog.md. If this PR did not mark a release, I added my changes into an# Unreleasedsection at the top..fossa.ymlorfossa-deps.{json.yml}, I updateddocs/references/files/*.schema.json. You may also need to update these if you have added/removed new dependency type (e.g.pip) or analysis target type (e.g.poetry).