Merged
Conversation
This reverts commit 81c02b4.
tjugdev
approved these changes
Feb 5, 2026
src/download-cli.ts
Outdated
| let selectedCliVersion: string; | ||
|
|
||
| if (PINNED_CLI_VERSION) { | ||
| const trimmed = PINNED_CLI_VERSION.trimStart(); |
There was a problem hiding this comment.
Suggested change
| const trimmed = PINNED_CLI_VERSION.trimStart(); | |
| const trimmed = PINNED_CLI_VERSION.trim(); |
Probably want to trim trailing spaces too, no?
src/download-cli.ts
Outdated
| debug(`Fetching new FOSSA version`); | ||
|
|
||
| if (await exec('bash', [installer, '-b', './fossa'], {...defaultOptions}) !== 0) { | ||
| const versionArgs = (selectedCliVersion !== '-1' && [selectedCliVersion]) || []; |
There was a problem hiding this comment.
How very bash-y
Suggested change
| const versionArgs = (selectedCliVersion !== '-1' && [selectedCliVersion]) || []; | |
| const versionArgs = selectedCliVersion !== '-1' ? [selectedCliVersion] : []; |
Contributor
Author
There was a problem hiding this comment.
Sometimes when you get in that head-space it's hard to jump back out...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Allow specifying a CLI version in our fossa-action.
Checklist
yarn buildand committed resulting changes..github/workflows/test.ymlor explained why it doesn't make sense to do so.Important
After merging, make sure to create a new GitHub release and associated tag for this release.
You can either create the tag locally and then create a corresponding GitHub release,
or just create both the tag and release using the GitHub Release UI.
Additionally, if this is not a breaking change, make sure to update the
v1tag: