Skip to content

fix end function when piping on request #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aaharu wants to merge 2 commits into from
Closed

fix end function when piping on request #832

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c4970c
fix end function when piping on request
Oct 19, 2021
45183e1
fix: fix end function when piping on request
aaharu Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ class Test extends Request {
* Defer invoking superagent's `.end()` until
* the server is listening.
*
* @param {Function} fn
* @param {?Function} fn
* @api public
*/
end(fn) {
Expand All @@ -133,7 +133,7 @@ class Test extends Request {
*
* @param {?Error} resError
* @param {Response} res
* @param {Function} fn
* @param {?Function} fn
Copy link
Collaborator

@titanism titanism Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please review your commit and fix these typos

* @api private
*/
assert(resError, res, fn) {
Expand Down Expand Up @@ -169,7 +169,9 @@ class Test extends Request {
errorObj = resError;
}

fn.call(this, errorObj || null, res);
if (fn) {
fn.call(this, errorObj || null, res);
}
}

/**
Expand Down