Skip to content

fix: missing domain API allowing filter by domain name #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

fix: missing domain API allowing filter by domain name #429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions app/controllers/web/my-account/list-domains.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
* SPDX-License-Identifier: BUSL-1.1
*/

const punycode = require('node:punycode');
const dayjs = require('dayjs-with-plugins');
const isSANB = require('is-string-and-not-blank');
const numeral = require('numeral');
Expand Down Expand Up @@ -118,6 +119,25 @@ async function listDomains(ctx, next) {

let { domains } = ctx.state;

//
// filter domains by domain name if query parameter is provided
//
if (isSANB(ctx.query.domain)) {
const domainQuery = ctx.query.domain.toLowerCase().trim();
// support both ASCII and Unicode domain names
const domainQueryASCII = punycode.toASCII(domainQuery);
const domainQueryUnicode = punycode.toUnicode(domainQuery);

domains = domains.filter((domain) => {
const domainName = domain.name.toLowerCase();
return (
domainName.includes(domainQuery) ||
domainName.includes(domainQueryASCII) ||
domainName.includes(domainQueryUnicode)
);
});
}

//
// starting November 1st we enforce API pagination on this endpoint
// (unless user opts in beforehand using ?pagination=true)
Expand Down
Loading