Fix: Support directory slashes in preprocessor include regex (#481)#527
Open
dhruvch12 wants to merge 2 commits into
Open
Fix: Support directory slashes in preprocessor include regex (#481)#527dhruvch12 wants to merge 2 commits into
dhruvch12 wants to merge 2 commits into
Conversation
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #527 +/- ##
=======================================
Coverage 44.43% 44.43%
=======================================
Files 35 35
Lines 4803 4803
=======================================
Hits 2134 2134
Misses 2669 2669 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves #481 where the
PP_INCLUDEregular expression failed to capture file paths containing directory slashes, causing the language server to miss include files in subdirectories.Changes Made
fortls/regex_patterns.pyto[\"\w\./\\]*so it properly parses both forward (/) and backward (\) slashes in paths.test/test_regex_patterns.pyusing the exact string from the issue report (#include "petsc/finclude/petscvec.h") to ensure the regex successfully extracts the full path.Additional Context
I am a prospective GSoC 2026 contributor and am submitting this patch as part of my application process. I am looking forward to any feedback!