Skip to content

Preallocate to please linter#157

Merged
ldemailly merged 1 commit intomainfrom
new_lint
Jan 17, 2026
Merged

Preallocate to please linter#157
ldemailly merged 1 commit intomainfrom
new_lint

Conversation

@ldemailly
Copy link
Member

@ldemailly ldemailly commented Jan 17, 2026

Avoids (new in 2.8.0)

$ golangci-lint run
dnsping.go:81:3: Consider preallocating keys (prealloc)
                keys := []string{}
                ^
1 issues:
* prealloc: 1

will fix #156 build once merged and rebased

@codecov
Copy link

codecov bot commented Jan 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.32%. Comparing base (29fb97a) to head (b157a87).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #157   +/-   ##
=======================================
  Coverage   91.32%   91.32%           
=======================================
  Files           1        1           
  Lines         173      173           
=======================================
  Hits          158      158           
  Misses         11       11           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ldemailly ldemailly merged commit 871b29b into main Jan 17, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants