Support letting enclaves do time keeping #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzohreva
previously approved these changes
Dec 2, 2024
Taowyoo
previously approved these changes
Dec 5, 2024
Base automatically changed from
raoul/rte-204-insecure_time_computation
to
master
December 12, 2024 14:01
raoulstrackx
dismissed stale reviews from Taowyoo and mzohreva
The base branch was changed.
raoulstrackx
force-pushed
the
raoul/rte-204-insecure_time_through_rdtscp
branch
from
a41c00b to
a34e976
Compare
Taowyoo
approved these changes
Dec 12, 2024
Member
|
Please add doc comments for the changes in fortanix-sgx-abi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SGXv2 platforms support calling the rdtscp instruction inside an enclave. This PR piggy backs on #659 that implemented logic to keep track of time. This PR starts using this logic in various tools and crates (e.g., async-usercalls, enclave-runner, ...).
Note that the enclave-runner does not change the returned value of
insecure_timeusercalls at this point; it will always return a null pointer as the second value in the returned tuple. These changes can thus be used on all existing enclaves, no new Rust compiler is required. Another PR will be filed to change the default behavior of enclave runner so enclaves by default take advantage of their improved hardware capabilities.