Address review feedback: deterministic tests, cached normalization, simplified promisePool

[Copilot]

Purpose

Resolves 3 outstanding review comments from PR actions#1045 review thread regarding test reliability, performance optimization, and API clarity.

Deterministic test delays

Replaced Math.random() * 10 with fixed 5ms delay in concurrency test mock. Non-deterministic delays cause flaky tests on slower runners and intermittent CI failures.

Pre-normalized cache values

Extended patchInfo structure to store ecoLower, pkgLower, and normalizedRange computed once during API fetch:

patchInfo[advId].push({
  eco: normalizedEco,
  pkg: pkgName,
  range: vulnRange,
  patch: patchVerId,
  ecoLower: normalizedEco,          // Cached
  pkgLower: pkgName.toLowerCase(),   // Cached
  normalizedRange: trimmedRange.replace(/,\s*/g, ' ')  // Cached
})

Rendering loop now uses cached values instead of repeating toLowerCase() and replace() for each vulnerability row.

Simplified promisePool signature

Changed from Promise<T[]> to Promise<void> and removed unused results array. Return values were never consumed; generic type parameter was misleading.

Related Issues

Addresses review comments in actions#1045 (review)

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Pull request overview

This PR addresses three specific review comments from PR actions#1045 related to test reliability, performance optimization, and API clarity. The changes improve code quality without introducing any functional changes.

Changes:

• Replaced non-deterministic test delay (Math.random() * 10) with fixed 5ms delay to prevent flaky tests
• Extended patchInfo structure to cache pre-normalized values (ecoLower, pkgLower, normalizedRange) computed once during API fetch
• Simplified promisePool function signature from Promise<T[]> to Promise<void> by removing unused results array and generic type parameter

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File	Description
src/summary.ts	Simplified promisePool signature to Promise, added pre-normalized cache fields to patchInfo structure, and updated rendering loop to use cached values
dist/index.js	Compiled JavaScript output matching the TypeScript changes in src/summary.ts
tests/summary.test.ts	Changed concurrency test from random delay to deterministic 5ms delay

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.