Skip to content

Replace obsolete macos-13 with macos-latest in GH-Actions #5057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MihailJP wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace obsolete macos-13 with macos-latest in GH-Actions #5057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9969936
Replace obsolete macos-13 with macos-latest in GH-Actions
MihailJP Feb 25, 2026
389fdbc
Suppress unsubscriptable-object false positive
MihailJP Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/install_run.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-13, windows-latest]
os: [ubuntu-latest, macos-latest, windows-latest]
profile:
- description: Universal profile on a static font
name: universal
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-13, windows-latest]
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: ["3.9", "3.10", "3.11", "3.12"]

steps:
Expand Down
2 changes: 2 additions & 0 deletions tests/test_checks_glyf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ def test_check_nested_components(check):

# We need to create a nested component. "second" has components, so setting
# one of "quotedbl"'s components to "second" should do it.
# pylint: disable=[E1136] # false positive
ttFont["glyf"]["quotedbl"].components[0].glyphName = "second"
# pylint: enable=[E1136]

assert_results_contain(check(ttFont), FAIL, "found-nested-components")
2 changes: 2 additions & 0 deletions tests/test_checks_opentype_glyf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,10 @@ def test_check_glyf_non_transformed_duplicate_components(check):
assert_PASS(check(ttFont))

# Set qutodbl's components to have the same x,y values
# pylint: disable=[E1136] # false positive
ttFont["glyf"]["quotedbl"].components[0].x = 0
ttFont["glyf"]["quotedbl"].components[1].x = 0
ttFont["glyf"]["quotedbl"].components[0].y = 0
ttFont["glyf"]["quotedbl"].components[1].y = 0
# pylint: enable=[E1136]
assert_results_contain(check(ttFont), FAIL, "found-duplicates")
2 changes: 2 additions & 0 deletions tests/test_checks_opentype_post.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,10 +194,12 @@ def test_check_italic_angle(check):

ttFont = TTFont(TEST_FILE("cairo/CairoPlay-Italic.rightslanted.ttf"))
assert_PASS(check(MockFont(ttFont=ttFont, style="Italic")))
# pylint: disable=[E1136] # false positive
ttFont["glyf"]["I"].endPtsOfContours = []
ttFont["glyf"]["I"].coordinates = []
ttFont["glyf"]["I"].flags = []
ttFont["glyf"]["I"].numberOfContours = 0
# pylint: enable=[E1136]
assert_results_contain(
check(MockFont(ttFont=ttFont, style="Italic")), WARN, "empty-glyphs"
)