-
Notifications
You must be signed in to change notification settings - Fork 138
Upgrade version of Tokio to ^1.0.1 #131
Conversation
|
And MapIo is marked as deprecated because it implements |
|
@rsdy I found that the compiling failed under Fedora but succeeded under Ubuntu. It seems that And the trait was resurrected in Oct 2020 by this PR A new structure implementing |
I don't think it's worth it, as it's quite an old release anyway. Realistically with Rust moving to newer LLVM versions, we're going to need to drop support for these anyway. I think targeting the latest stable compiler is reasonable. |
|
@rsdy OK. That's more convenient way to develop this. |
rsdy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good first step. Removing deprecations can come at a later stage.
|
Actually all the builds fail, and Fedora too. The fact that Ubuntu builds go through is a separate bug in the CircleCI files. |
|
@rsdy Is there something that should be done in order to merge this PR? |
|
I am currently fixing the CI scripts. I'd prefer if we resolved that issue before merging this PR. |
|
It looks like I misread the CI output. I'll merge this. Thanks! |
This resolves #129 issue.
All example programs work as expected.
All packages of workspace are compiled successfully with stable rust 1.51.0.