Feature: Allowing for batch file creation when the generated KPP file exceeds the file size limit#21
Open
Feature: Allowing for batch file creation when the generated KPP file exceeds the file size limit#21
Conversation
… for performing checks before saving the generated file
…sabling logic for batch file creation
…de file with a single institution ID
…Utils, and adding a buffer in the calculation
…he Args object in the batch file tests
astride
force-pushed
the
feature/didop-7690-splitlargefiles
branch
from
d9136b8 to
ab1b467
Compare
astride
force-pushed
the
feature/didop-7690-splitlargefiles
branch
from
9b0d3e9 to
be8cf03
Compare
astride
commented
Sep 1, 2025
Collaborator
Author
|
Versjonsnummeret må oppdateres. Se veiledning. Håndtert i 28d36e2 |
…an XML file' logic, so that the resulting file size is directly accessible from disk
astride
commented
Sep 2, 2025
astride
commented
Sep 3, 2025
| {"epj-versjon=", "Versjon av EPJ", x => kppArgs.VersjonEpj = x }, | ||
| {"fhi-herid=", "FHIs HerId.", x => kppArgs.FhiHerId = x }, | ||
| {"batchfiles-enable=", "'true' dersom det er ønskelig å opprette delmeldinger om KPP-meldingen blir for stor", x => kppArgs.BatchFiles.EnableCreation = ParseBool(x) }, | ||
| {"batchfiles-maxfilesize=", "Maks. filstørrelse for KPP-meldingen i gigabyte (GB)", x => kppArgs.BatchFiles.MaxFileSizeInGigabytes = ParseInt(x) }, |
Collaborator
Author
There was a problem hiding this comment.
De to batchfiles-*-input-argumentene er bredere enn de eksisterende argumentene. Når man kjører
.\Dhhr.KppParser.ConsoleApp.exe -hfor å vise veiledning for konsollapplikasjonen, ser det ikke så pent ut:
Har forsøkt å se på om det går an å konfigurere Mono.Options.OptionSet eller Mono.Options.OptionSet.WriteOptionDescriptions() for å øke avstanden mellom første og andre kolonne, men har ikke blitt klok på om det er mulig.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: The KPP service can create batch files (delmeldinger) when the generated KPP file (
xmlfile) exceeds the maximum file size limit. The file size limit is only evaluated (and only needs to be provided) when the feature is enabled.Both the GUI application and the console application supports the creation of batch files.
Batch file creation is not available for episode files containing episodes associated with more than one institution.
Unit tests have been added to test different batch file scenarios.