-
Notifications
You must be signed in to change notification settings - Fork 64
Use preventScroll option on deactivation #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: eb0d456 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stefcameron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jhnns Thanks for the fix! 😄
My pleasure! |
|
Ready to be reviewed again :) |
stefcameron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the changes. I'll merge once CI succeeds.
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
==========================================
+ Coverage 96.55% 96.58% +0.02%
==========================================
Files 1 1
Lines 116 117 +1
Branches 45 46 +1
==========================================
+ Hits 112 113 +1
Misses 4 4
Continue to review full report at Codecov.
|
|
@all-contributors add @jhnns for code |
|
I've put up a pull request to add @jhnns! 🎉 |
Hi there 👋
thanks for this awesome package ❤️.
I noticed that the current implementation ignores the
preventScrolloption when returning focus on deactivation. In order to align with focus-trap (which setspreventScrollon deactivation), I think focus-trap-react should also use this option.What do you think? 😀
PR Checklist
Please leave this checklist in your PR.
typeof document/window !== 'undefined'before using it in code that gets executed on load.yarn changesetlocally to add one, and follow the prompts).