Skip to content

adding support for node 20 and deprecating support for node16 and node 14 as they reached their support end date #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VikashLNU merged 1 commit into from
Apr 1, 2024
Merged

adding support for node 20 and deprecating support for node16 and node 14 as they reached their support end date #681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions RELEASES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@

# Releases

## v 0.6.31

* Enabling support for node20
* Removing support for node16, node 14

## v 0.6.30
*
* Fix security vulnerability issue
Expand Down
5 changes: 2 additions & 3 deletions langs/base.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,8 @@ func init() {
registerHelper(&JavaLangHelper{version: "17"})
registerHelper(&JavaLangHelper{version: "11"})
registerHelper(&JavaLangHelper{version: "8"})
registerHelper(&NodeLangHelper{Version: "20"})
registerHelper(&NodeLangHelper{Version: "18"})
registerHelper(&NodeLangHelper{Version: "16"})
registerHelper(&NodeLangHelper{Version: "14"})
// order matter, 'python' will pick up the first PythonLangHelper
registerHelper(&PythonLangHelper{Version: "3.11"})
registerHelper(&PythonLangHelper{Version: "3.9"})
Expand All @@ -56,7 +55,7 @@ func init() {

// for older versions support backwards compatibility
fallBackOlderVersions["ruby"] = &RubyLangHelper{Version: "3.1"}
fallBackOlderVersions["node"] = &NodeLangHelper{Version: "11"}
fallBackOlderVersions["node"] = &NodeLangHelper{Version: "16"}
fallBackOlderVersions["go"] = &GoLangHelper{Version: "1.11"}
}

Expand Down
3 changes: 1 addition & 2 deletions test/cli_init_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,8 @@ var runtimes = []string{
"ruby",
"ruby3.1",
"node",
"node20",
"node18",
"node16",
"node14",
"python",
"python3.11",
"python3.9",
Expand Down
3 changes: 1 addition & 2 deletions test/cli_lang_boilerplate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,8 @@ var Runtimes = []struct {
{"java17", ""},
{"kotlin", ""},
{"node", ""},
{"node20", ""},
{"node18", ""},
{"node16", ""},
{"node14", ""},
{"ruby", ""},
{"ruby3.1", ""},
{"python", ""},
Expand Down