Skip to content

Move a few classes into an anonymous namespace #4713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitaut merged 2 commits into from
Mar 15, 2026
+4 −0
Merged

Move a few classes into an anonymous namespace #4713

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f97e6d
Move a few classes into an anonymous namespace
localspook Mar 12, 2026
76d5acf
Move back FMT_BEGIN_NAMESPACE
localspook Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/os.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@
# endif
#endif

FMT_BEGIN_NAMESPACE
Comment thread
localspook marked this conversation as resolved.
Outdated

namespace {
#ifdef _WIN32
// Return type of read and write functions.
Expand All @@ -77,11 +79,11 @@ inline auto convert_rwcount(size_t count) -> size_t { return count; }
#endif
} // namespace

FMT_BEGIN_NAMESPACE

#ifdef _WIN32
namespace detail {

namespace {

class system_message {
system_message(const system_message&) = delete;
void operator=(const system_message&) = delete;
Expand Down Expand Up @@ -129,6 +131,8 @@ class utf8_system_category final : public std::error_category {
}
};

} // namespace

} // namespace detail

FMT_API const std::error_category& system_category() noexcept {
Expand Down
Loading