-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Interpret precision as display width #4443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4c11646
use display width precision
nikhilreddydev 9609f0d
use constexpr to compile only relevant branch
nikhilreddydev 07cf0ce
use enable_if
nikhilreddydev 4857e73
fix formatting
nikhilreddydev b80b43d
handle unused parameters
nikhilreddydev 0b6c4e0
remove unnecessay include
nikhilreddydev 03b6f3a
Remove unnecessary data parameter
nikhilreddydev c573671
arguments are already unsigned
nikhilreddydev dd25ea9
Add test case for introduced function count_code_points_with_display_…
nikhilreddydev 93fabd0
Test fmt::format for display width precision end to end instead of ju…
nikhilreddydev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's test the output of
fmt::formatinstead of this internal function to make sure that precision computation works end-to-end.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is done as part of 93fabd0
Thank you!