Skip to content

Mark namespace scope constexpr variable 'buffer_size' inline. #4084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitaut merged 2 commits into from
Jul 24, 2024
+1 −1
Merged

Mark namespace scope constexpr variable 'buffer_size' inline. #4084

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf40a75
Mark namespace scope constexpr variable 'buffer_size' inline.
kamrann Jul 23, 2024
209dfb3
Use provided macro for inline variable.
kamrann Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/fmt/os.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ class file_buffer final : public buffer<char> {

} // namespace detail

constexpr auto buffer_size = detail::buffer_size();
FMT_INLINE_VARIABLE constexpr auto buffer_size = detail::buffer_size();

/// A fast output stream for writing from a single thread. Writing from
/// multiple threads without external synchronization may result in a data race.
Expand Down