Skip to content

Proxy image#27

Merged
fmoorhof merged 2 commits intomainfrom
proxy-image
Mar 20, 2026
Merged

Proxy image#27
fmoorhof merged 2 commits intomainfrom
proxy-image

Conversation

@fmoorhof
Copy link
Copy Markdown
Owner

@fmoorhof fmoorhof commented Mar 20, 2026

Summary by Sourcery

Update Docker images and workflows to use selectzyme proxy and app containers and introduce a dedicated proxy image build pipeline.

Build:

  • Switch docker-compose to use the prebuilt selectzyme-proxy container image from docker container registry instead of a local nginx setup.
  • Bump all selectzyme app services in docker-compose from image version 0.0.4 to 0.0.5.
  • Add a Dockerfile under nginx/ to build the dedicated proxy image and include static assets.

CI:

  • Rename and adjust the app image publish workflow to explicitly target the selectzyme app image at version 0.0.5.
  • Add a new GitHub Actions workflow to build and publish the selectzyme proxy Docker image from the nginx context.

@fmoorhof fmoorhof added this to the deployment milestone Mar 20, 2026
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Mar 20, 2026

Reviewer's Guide

This PR introduces a dedicated Docker image and CI workflow for the Nginx proxy, updates all selectzyme application services and workflows to version 0.0.5, and adjusts static asset paths and documentation to match the new proxy container layout.

File-Level Changes

Change Details Files
Switch proxy service in docker-compose to use a prebuilt proxy image instead of mounting local Nginx configuration and assets.
  • Update selectzyme-proxy service image to ghcr.io/ipb-halle/selectzyme-proxy:0.0.5
  • Remove bind-mounted Nginx config and static files from the proxy service definition
  • Keep port mapping commented but normalized for potential local use
docker-compose.yml
Bump all selectzyme application services to image version 0.0.5.
  • Update image tag from 0.0.4 to 0.0.5 for selectzyme-demo, selectzyme-petase, selectzyme-ired, selectzyme-lpor, selectzyme-lov, and selectzyme-fmos services
docker-compose.yml
Clarify architecture diagram terminology in the README to reflect a generic infrastructure proxy and shared app proxy.
  • Rename "Biocloud Proxy" to "Infrastructure Proxy" in the mermaid sequence diagram
  • Rename "Selectzyme Demo Proxy (nginx)" to "Proxy (nginx)" and "Selectzyme Demo App" to "Selectzyme App"
  • Adjust interaction description text to match the more generic naming
README.md
Rename and tweak the existing Docker publish workflow for the app image and bump its version.
  • Rename workflow file to docker-publish-selectzyme-app.yml and workflow name to "Build and publish Docker selectzyme image"
  • Change SELECTZYME_VERSION env var to 0.0.5
  • Update the final build step name to reference the selectzyme image explicitly
.github/workflows/docker-publish-selectzyme-app.yml
Introduce a dedicated CI workflow to build and publish the proxy Docker image from the nginx directory.
  • Create docker-publish-proxy workflow with its own SELECTZYME_VERSION and image metadata
  • Configure build context to ./nginx and enable push with generated tags and OCI labels
  • Set no-cache build to ensure fresh proxy image builds
.github/workflows/docker-publish-proxy.yml
Package Nginx proxy configuration and static assets into a Docker image build context.
  • Add a Dockerfile that derives from nginx:alpine and copies default.conf, index.html, bootstrap.min.css, and ipb-logo.png into the Nginx document root
  • Rely on the base image CMD/ENTRYPOINT rather than overriding them
nginx/Dockerfile
Adjust index.html to match new asset layout inside the proxy image.
  • Change logo image reference from assets/ipb-logo.png to ipb-logo.png in index.html to align with the new copy location in the Docker image
nginx/index.html

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • The new proxy publish workflow pushes to ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ env.SELECTZYME_VERSION }} but docker-compose.yml references ghcr.io/ipb-halle/selectzyme-proxy:0.0.5, so you may want to align the image name/namespace (or adjust IMAGE_NAME) to ensure the compose file pulls the image actually built by the workflow.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The new proxy publish workflow pushes to `${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ env.SELECTZYME_VERSION }}` but `docker-compose.yml` references `ghcr.io/ipb-halle/selectzyme-proxy:0.0.5`, so you may want to align the image name/namespace (or adjust `IMAGE_NAME`) to ensure the compose file pulls the image actually built by the workflow.

## Individual Comments

### Comment 1
<location path=".github/workflows/docker-publish-proxy.yml" line_range="9-18" />
<code_context>
+env:
+  REGISTRY: ghcr.io
+  SELECTZYME_VERSION: 0.0.5
+  IMAGE_NAME: ${{ github.repository }}
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    permissions:
+      contents: read
+      packages: write
+      id-token: write
+
+    steps:
+    - name: Check out repository
+      uses: actions/checkout@v5
+
+    - name: Set up Docker Buildx
+      uses: docker/setup-buildx-action@v3
+
+    - name: Log into registry ${{ env.REGISTRY }}
+      uses: docker/login-action@v3
+      with:
+        registry: ${{ env.REGISTRY }}
+        username: ${{ github.actor }}
+        password: ${{ secrets.GITHUB_TOKEN }}
+
+    - name: Extract Docker metadata
+      id: meta
+      uses: docker/metadata-action@v5
+      with:
+        images: |
+          ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
+        tags:
</code_context>
<issue_to_address>
**issue (bug_risk):** The published proxy image name does not match the image reference used in docker-compose.

In `docker-compose.yml` the proxy service uses `ghcr.io/ipb-halle/selectzyme-proxy:0.0.5`, but this workflow publishes to `ghcr.io/<org>/<repo>:0.0.5` via `${{ github.repository }}`. The proxy image therefore won’t be published under the name used by compose. Please either set `IMAGE_NAME` explicitly to `ipb-halle/selectzyme-proxy` or override `images:` so it matches the compose reference.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment on lines +9 to +18
IMAGE_NAME: ${{ github.repository }}

jobs:
build:
runs-on: ubuntu-latest

permissions:
contents: read
packages: write
id-token: write
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): The published proxy image name does not match the image reference used in docker-compose.

In docker-compose.yml the proxy service uses ghcr.io/ipb-halle/selectzyme-proxy:0.0.5, but this workflow publishes to ghcr.io/<org>/<repo>:0.0.5 via ${{ github.repository }}. The proxy image therefore won’t be published under the name used by compose. Please either set IMAGE_NAME explicitly to ipb-halle/selectzyme-proxy or override images: so it matches the compose reference.

@fmoorhof fmoorhof merged commit ad8b65a into main Mar 20, 2026
4 checks passed
@fmoorhof fmoorhof deleted the proxy-image branch March 20, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant