Conversation
Reviewer's GuideThis PR introduces a dedicated Docker image and CI workflow for the Nginx proxy, updates all selectzyme application services and workflows to version 0.0.5, and adjusts static asset paths and documentation to match the new proxy container layout. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The new proxy publish workflow pushes to
${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ env.SELECTZYME_VERSION }}butdocker-compose.ymlreferencesghcr.io/ipb-halle/selectzyme-proxy:0.0.5, so you may want to align the image name/namespace (or adjustIMAGE_NAME) to ensure the compose file pulls the image actually built by the workflow.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new proxy publish workflow pushes to `${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ env.SELECTZYME_VERSION }}` but `docker-compose.yml` references `ghcr.io/ipb-halle/selectzyme-proxy:0.0.5`, so you may want to align the image name/namespace (or adjust `IMAGE_NAME`) to ensure the compose file pulls the image actually built by the workflow.
## Individual Comments
### Comment 1
<location path=".github/workflows/docker-publish-proxy.yml" line_range="9-18" />
<code_context>
+env:
+ REGISTRY: ghcr.io
+ SELECTZYME_VERSION: 0.0.5
+ IMAGE_NAME: ${{ github.repository }}
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+
+ permissions:
+ contents: read
+ packages: write
+ id-token: write
+
+ steps:
+ - name: Check out repository
+ uses: actions/checkout@v5
+
+ - name: Set up Docker Buildx
+ uses: docker/setup-buildx-action@v3
+
+ - name: Log into registry ${{ env.REGISTRY }}
+ uses: docker/login-action@v3
+ with:
+ registry: ${{ env.REGISTRY }}
+ username: ${{ github.actor }}
+ password: ${{ secrets.GITHUB_TOKEN }}
+
+ - name: Extract Docker metadata
+ id: meta
+ uses: docker/metadata-action@v5
+ with:
+ images: |
+ ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
+ tags:
</code_context>
<issue_to_address>
**issue (bug_risk):** The published proxy image name does not match the image reference used in docker-compose.
In `docker-compose.yml` the proxy service uses `ghcr.io/ipb-halle/selectzyme-proxy:0.0.5`, but this workflow publishes to `ghcr.io/<org>/<repo>:0.0.5` via `${{ github.repository }}`. The proxy image therefore won’t be published under the name used by compose. Please either set `IMAGE_NAME` explicitly to `ipb-halle/selectzyme-proxy` or override `images:` so it matches the compose reference.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| IMAGE_NAME: ${{ github.repository }} | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| permissions: | ||
| contents: read | ||
| packages: write | ||
| id-token: write |
There was a problem hiding this comment.
issue (bug_risk): The published proxy image name does not match the image reference used in docker-compose.
In docker-compose.yml the proxy service uses ghcr.io/ipb-halle/selectzyme-proxy:0.0.5, but this workflow publishes to ghcr.io/<org>/<repo>:0.0.5 via ${{ github.repository }}. The proxy image therefore won’t be published under the name used by compose. Please either set IMAGE_NAME explicitly to ipb-halle/selectzyme-proxy or override images: so it matches the compose reference.
Summary by Sourcery
Update Docker images and workflows to use selectzyme proxy and app containers and introduce a dedicated proxy image build pipeline.
Build:
CI: