feat: Add option to mute alerts generated from webhooks#887
Merged
stefanprodan merged 2 commits intofluxcd:mainfrom Apr 28, 2021
Merged
feat: Add option to mute alerts generated from webhooks#887stefanprodan merged 2 commits intofluxcd:mainfrom
stefanprodan merged 2 commits intofluxcd:mainfrom
Conversation
Signed-off-by: Mayank Shah <mayankshah1614@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #887 +/- ##
==========================================
- Coverage 56.68% 56.61% -0.07%
==========================================
Files 67 67
Lines 5439 5442 +3
==========================================
- Hits 3083 3081 -2
- Misses 1896 1901 +5
Partials 460 460
Continue to review full report at Codecov.
|
Signed-off-by: Mayank Shah <mayankshah1614@gmail.com>
stefanprodan
approved these changes
Apr 28, 2021
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @mayankshah1607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternate solution for #886
Signed-off-by: Mayank Shah mayankshah1614@gmail.com