Skip to content

Scale up canary on confirm rollout#878

Merged
stefanprodan merged 1 commit intofluxcd:mainfrom
AlonGluz:bugfix/scale-up-canary-after-confirm-rollout
Apr 29, 2021
Merged

Scale up canary on confirm rollout#878
stefanprodan merged 1 commit intofluxcd:mainfrom
AlonGluz:bugfix/scale-up-canary-after-confirm-rollout

Conversation

@AlonGluz
Copy link
Contributor

@AlonGluz AlonGluz commented Apr 7, 2021

fix: #669
fix: #874

@codecov-io
Copy link

Codecov Report

Merging #878 (51ecb2e) into main (e6c740d) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #878      +/-   ##
==========================================
- Coverage   56.71%   56.68%   -0.04%     
==========================================
  Files          67       67              
  Lines        5439     5439              
==========================================
- Hits         3085     3083       -2     
- Misses       1894     1896       +2     
  Partials      460      460              
Impacted Files Coverage Δ
pkg/controller/scheduler_hooks.go 9.23% <0.00%> (ø)
pkg/canary/config_tracker.go 83.25% <0.00%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6c740d...51ecb2e. Read the comment docs.

@AlonGluz AlonGluz changed the title AlonGluz:bugfix/scale-up-canary-after-confirm-rollout AlonGluz:bugfix/scale-up-canary-after-confirm-rollout fix: #669 Apr 21, 2021
@AlonGluz AlonGluz force-pushed the bugfix/scale-up-canary-after-confirm-rollout branch 2 times, most recently from 2450c1e to 8726308 Compare April 21, 2021 13:33
@stefanprodan stefanprodan changed the title AlonGluz:bugfix/scale-up-canary-after-confirm-rollout fix: #669 Scale canary on confirm rollout Apr 21, 2021
@stefanprodan stefanprodan changed the title Scale canary on confirm rollout Scale up canary on confirm rollout Apr 21, 2021
@stefanprodan
Copy link
Member

@AlonGluz can you please squash all commits and confirm this is working as expected on your cluster?

@AlonGluz
Copy link
Contributor Author

@stefanprodan, sure thing.

@AlonGluz AlonGluz force-pushed the bugfix/scale-up-canary-after-confirm-rollout branch from 8726308 to 9fe6bb0 Compare April 29, 2021 08:30
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2021

Codecov Report

Merging #878 (8726308) into main (fcac992) will increase coverage by 0.06%.
The diff coverage is 0.00%.

❗ Current head 8726308 differs from pull request most recent head 92f4be7. Consider uploading reports for the commit 92f4be7 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #878      +/-   ##
==========================================
+ Coverage   56.58%   56.65%   +0.06%     
==========================================
  Files          68       67       -1     
  Lines        5565     5442     -123     
==========================================
- Hits         3149     3083      -66     
+ Misses       1946     1899      -47     
+ Partials      470      460      -10     
Impacted Files Coverage Δ
pkg/controller/scheduler_hooks.go 8.82% <0.00%> (ø)
pkg/controller/webhook.go 64.70% <0.00%> (-1.34%) ⬇️
pkg/notifier/teams.go 76.00% <0.00%> (-0.93%) ⬇️
pkg/notifier/discord.go 71.42% <0.00%> (-0.80%) ⬇️
pkg/notifier/slack.go 75.00% <0.00%> (-0.76%) ⬇️
pkg/notifier/rocket.go 75.00% <0.00%> (-0.76%) ⬇️
pkg/router/factory.go 0.00% <0.00%> (ø)
pkg/notifier/factory.go 0.00% <0.00%> (ø)
pkg/canary/config_tracker.go 83.25% <0.00%> (ø)
pkg/router/smi_v1alpha2.go
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcac992...92f4be7. Read the comment docs.

@AlonGluz AlonGluz force-pushed the bugfix/scale-up-canary-after-confirm-rollout branch from 9fe6bb0 to a3ac75e Compare April 29, 2021 08:36
@AlonGluz AlonGluz force-pushed the bugfix/scale-up-canary-after-confirm-rollout branch from a3ac75e to 92f4be7 Compare April 29, 2021 08:37
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @AlonGluz 🏅

@stefanprodan stefanprodan merged commit 2ed9ddc into fluxcd:main Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Canary deployment receives traffic even if has zero pods using the confirm-rollout webhook confirm-rollout and pre-rollout not working as expected

4 participants