Merged
Conversation
Design by Bianca Cheng Costanzo Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Collaborator
|
I just reviewed the diagrams, here's the list that need updating: Remove
Update
Let me know if you want me to file a PR to change the following: Docs: diff --git docs/gitbook/tutorials/canary-helm-gitops.md docs/gitbook/tutorials/canary-helm-gitops.md
index f27355c2..2d1e57f6 100644
--- docs/gitbook/tutorials/canary-helm-gitops.md
+++ docs/gitbook/tutorials/canary-helm-gitops.md
@@ -266,7 +266,7 @@ metadata:
spec:
releaseName: frontend
chart:
- git: https://github.com/weaveowrks/flagger
+ git: https://github.com/fluxcd/flagger
ref: master
path: charts/podinfo
values:
|
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Collaborator
|
Nice work @stefanprodan - I noticed |
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Member
Author
|
The canary-helm-gitops.md is no longer used and will be deleted. As for the GKE diagram, the Istio logo is ok as it shows Flagger manipulating Istio object. |
Member
Author
|
As for the weaveworks SVGs, I can't delete that until we update Flagger in the Cloud Native Landscape. |
Collaborator
|
^ this is in the GKE diagram.. |
Collaborator
|
Apart from that big 👍 ! |
Collaborator
|
Ah ok nevermind - I understood your comment now. |
dholbach
approved these changes
Feb 15, 2021
Collaborator
dholbach
left a comment
dholbach
left a comment
There was a problem hiding this comment.
Great work @stefanprodan!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: